Bug 142161

Summary: [WK2] Remove unnecessary create() factory functions
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: WebKit2Assignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Archive of layout-test-results from ews107 for mac-mavericks-wk2
none
Patch none

Gyuyoung Kim
Reported 2015-03-02 04:32:31 PST
We can replace some create() factory functions with std::make_unique(). Because it just returns new instance. Even some of those functions have used std::unique_ptr<> instead of std::make_unique<>.
Attachments
Patch (7.83 KB, patch)
2015-03-02 04:36 PST, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Patch (9.65 KB, patch)
2015-03-02 07:50 PST, EFL EWS Bot 		no flags
DetailsFormatted DiffDiff
Patch (9.65 KB, patch)
2015-03-02 07:51 PST, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews107 for mac-mavericks-wk2 (715.09 KB, application/zip)
2015-03-02 08:43 PST, Build Bot 		no flags
Details
Patch (9.68 KB, patch)
2015-03-02 16:27 PST, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2015-03-02 04:36:44 PST
Created attachment 247659 [details] Patch
EFL EWS Bot
Comment 2 2015-03-02 07:50:14 PST
Created attachment 247665 [details] Patch
Gyuyoung Kim
Comment 3 2015-03-02 07:51:31 PST
Created attachment 247666 [details] Patch
Build Bot
Comment 4 2015-03-02 08:43:53 PST
Comment on attachment 247666 [details] Patch Attachment 247666 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5423996413673472 New failing tests: fast/css/object-fit/object-fit-canvas.html
Build Bot
Comment 5 2015-03-02 08:43:56 PST
Created attachment 247670 [details] Archive of layout-test-results from ews107 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Gyuyoung Kim
Comment 6 2015-03-02 16:27:40 PST
Created attachment 247716 [details] Patch
Chris Dumez
Comment 7 2015-03-02 21:32:42 PST
Comment on attachment 247716 [details] Patch r=me
WebKit Commit Bot
Comment 8 2015-03-02 22:56:00 PST
Comment on attachment 247716 [details] Patch Clearing flags on attachment: 247716 Committed r180921: <http://trac.webkit.org/changeset/180921>
WebKit Commit Bot
Comment 9 2015-03-02 22:56:03 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.