Bug 142161

Summary: [WK2] Remove unnecessary create() factory functions
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: WebKit2Assignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Archive of layout-test-results from ews107 for mac-mavericks-wk2
none
Patch none

Description Gyuyoung Kim 2015-03-02 04:32:31 PST 
We can replace some create() factory functions with std::make_unique(). Because it just returns new instance. Even some of those functions have used std::unique_ptr<> instead of std::make_unique<>.
Comment 1 Gyuyoung Kim 2015-03-02 04:36:44 PST 
Created attachment 247659 [details]
Patch
Comment 2 EFL EWS Bot 2015-03-02 07:50:14 PST 
Created attachment 247665 [details]
Patch
Comment 3 Gyuyoung Kim 2015-03-02 07:51:31 PST 
Created attachment 247666 [details]
Patch
Comment 4 Build Bot 2015-03-02 08:43:53 PST 
Comment on attachment 247666 [details]
Patch

Attachment 247666 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5423996413673472

New failing tests:
fast/css/object-fit/object-fit-canvas.html
Comment 5 Build Bot 2015-03-02 08:43:56 PST 
Created attachment 247670 [details]
Archive of layout-test-results from ews107 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5
Comment 6 Gyuyoung Kim 2015-03-02 16:27:40 PST 
Created attachment 247716 [details]
Patch
Comment 7 Chris Dumez 2015-03-02 21:32:42 PST 
Comment on attachment 247716 [details]
Patch

r=me
Comment 8 WebKit Commit Bot 2015-03-02 22:56:00 PST 
Comment on attachment 247716 [details]
Patch

Clearing flags on attachment: 247716

Committed r180921: <http://trac.webkit.org/changeset/180921>
Comment 9 WebKit Commit Bot 2015-03-02 22:56:03 PST 
All reviewed patches have been landed.  Closing bug.