Summary: | [EFL][GTK] Fix build break after r180790,180798 | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Hunseop Jeong <hs85.jeong> | ||||||||
Component: | WebKit EFL | Assignee: | Hunseop Jeong <hs85.jeong> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, dino, d-r, gyuyoung.kim, krit, lucas.de.marchi, ossy, sam, thorton | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 82791, 142109 | ||||||||||
Attachments: |
|
Description
Hunseop Jeong
2015-02-27 21:50:47 PST
Need to implement the "addEllipse(FloatPoint, float radiusX, float radiusY, float rotation, float startAngle, float endAngle, bool anticlockwise);" in PathCairo. Created attachment 247590 [details]
HotFix
After this patch, another build break occurred : Source/WebKit2/CMakeFiles/WebKit2.dir/WebProcess/WebPage/WebFrame.cpp.o:WebFrame.cpp:function WebKit::WebFrame::jsWrapperForWorld(WebKit::InjectedBundleFileHandle*, WebKit::InjectedBundleScriptWorld*): error: undefined reference to 'WebKit::InjectedBundleFileHandle::coreFile()' collect2: error: ld returned 1 exit status (In reply to comment #3) > After this patch, another build break occurred : > > Source/WebKit2/CMakeFiles/WebKit2.dir/WebProcess/WebPage/WebFrame.cpp.o: > WebFrame.cpp:function > WebKit::WebFrame::jsWrapperForWorld(WebKit::InjectedBundleFileHandle*, > WebKit::InjectedBundleScriptWorld*): error: undefined reference to > 'WebKit::InjectedBundleFileHandle::coreFile()' > collect2: error: ld returned 1 exit status Please fix it as well. Created attachment 247591 [details]
Patch
Comment on attachment 247591 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=247591&action=review > Source/WebCore/platform/graphics/cairo/PathCairo.cpp:289 > + // FIXME: Need to implement the Path::addEllipse(). Looks like a redundant comment. "notImplement()" is enough. Created attachment 247592 [details]
Patch
Comment on attachment 247592 [details] Patch Clearing flags on attachment: 247592 Committed r180817: <http://trac.webkit.org/changeset/180817> All reviewed patches have been landed. Closing bug. |