Bug 142127

Summary: [EFL][GTK] Fix build break after r180790,180798
Product: WebKit Reporter: Hunseop Jeong <hs85.jeong>
Component: WebKit EFLAssignee: Hunseop Jeong <hs85.jeong>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, d-r, gyuyoung.kim, krit, lucas.de.marchi, ossy, sam, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 82791, 142109    
Attachments:
Description Flags
HotFix
none
Patch
none
Patch none

Description Hunseop Jeong 2015-02-27 21:50:47 PST
CanvasPathMethods.cpp:(.text._ZN7WebCore17CanvasPathMethods7ellipseEfffffffbRi+0x306): undefined reference to `WebCore::Path::addEllipse(WebCore::FloatPoint, float, float, float, float, float, bool)'
collect2: error: ld returned 1 exit status
Comment 1 Hunseop Jeong 2015-02-27 21:54:24 PST
Need to implement the "addEllipse(FloatPoint, float radiusX, float radiusY, float rotation, float startAngle, float endAngle, bool anticlockwise);" in PathCairo.
Comment 2 Hunseop Jeong 2015-02-27 22:26:35 PST
Created attachment 247590 [details]
HotFix
Comment 3 Hunseop Jeong 2015-02-27 22:29:08 PST
After this patch, another build break occurred :

Source/WebKit2/CMakeFiles/WebKit2.dir/WebProcess/WebPage/WebFrame.cpp.o:WebFrame.cpp:function WebKit::WebFrame::jsWrapperForWorld(WebKit::InjectedBundleFileHandle*, WebKit::InjectedBundleScriptWorld*): error: undefined reference to 'WebKit::InjectedBundleFileHandle::coreFile()'
collect2: error: ld returned 1 exit status
Comment 4 Gyuyoung Kim 2015-02-27 22:33:49 PST
(In reply to comment #3)
> After this patch, another build break occurred :
> 
> Source/WebKit2/CMakeFiles/WebKit2.dir/WebProcess/WebPage/WebFrame.cpp.o:
> WebFrame.cpp:function
> WebKit::WebFrame::jsWrapperForWorld(WebKit::InjectedBundleFileHandle*,
> WebKit::InjectedBundleScriptWorld*): error: undefined reference to
> 'WebKit::InjectedBundleFileHandle::coreFile()'
> collect2: error: ld returned 1 exit status

Please fix it as well.
Comment 5 Hunseop Jeong 2015-02-27 22:37:41 PST
Created attachment 247591 [details]
Patch
Comment 6 Gyuyoung Kim 2015-02-27 22:39:35 PST
Comment on attachment 247591 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=247591&action=review

> Source/WebCore/platform/graphics/cairo/PathCairo.cpp:289
> +    // FIXME: Need to implement the Path::addEllipse().

Looks like a redundant comment. "notImplement()" is enough.
Comment 7 Hunseop Jeong 2015-02-27 22:41:46 PST
Created attachment 247592 [details]
Patch
Comment 8 Csaba Osztrogon√°c 2015-02-27 23:26:24 PST
Comment on attachment 247592 [details]
Patch

Clearing flags on attachment: 247592

Committed r180817: <http://trac.webkit.org/changeset/180817>
Comment 9 Csaba Osztrogon√°c 2015-02-27 23:26:34 PST
All reviewed patches have been landed.  Closing bug.