Bug 142065

Summary:

Subpixel-layout: width: max-content; property might cause unnecessary scrollbar.

Product:

WebKit

Reporter:

Myles C. Maxfield <mmaxfield>

Component:

Layout and Rendering

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, esprehn+autocc, glenn, kondapallykalyan, rniwa, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Reduction	none
Patch	none
Patch	none
Archive of layout-test-results from ews107 for mac-mavericks-wk2	none
Patch	none

Description Myles C. Maxfield 2015-02-26 17:21:33 PST

Caused by RootInlineBox::paddedLayoutOverflowRect(). This increases the apparent size of the inline content (pixelSnappedLogicalRight() calls ceilf()), but RenderLayer::hasHorizontalOverflow() compares that against renderBox()->pixelSnappedClientWidth(), which simply rounds.

Comment 1 Myles C. Maxfield 2015-02-26 17:22:06 PST

Causes fast/css-intrinsic-dimensions/width-avoid-floats.html to fail.

Comment 2 Myles C. Maxfield 2015-02-26 17:22:33 PST

Created attachment 247472 [details]
Reduction

Comment 3 Radar WebKit Bug Importer 2015-02-26 17:23:37 PST

<rdar://problem/19979430>

Comment 4 zalan 2015-02-27 15:43:52 PST

Created attachment 247566 [details]
Patch

Comment 5 Simon Fraser (smfr) 2015-02-27 15:46:24 PST

Comment on attachment 247566 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=247566&action=review

> Source/WebCore/rendering/RootInlineBox.cpp:840
>      // FIXME: Audit whether to use pixel snapped values when not using integers for layout: https://bugs.webkit.org/show_bug.cgi?id=63656

Remove?

Comment 6 zalan 2015-02-27 15:48:47 PST

Created attachment 247567 [details]
Patch

Comment 7 zalan 2015-02-27 15:49:07 PST

Comment on attachment 247567 [details]
Patch

EWS testing.

Comment 8 Build Bot 2015-02-27 16:33:15 PST

Comment on attachment 247567 [details]
Patch

Attachment 247567 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/4958076213919744

New failing tests:
fast/forms/control-restrict-line-height.html
fast/css/text-overflow-input.html
editing/input/caret-at-the-edge-of-input.html
fast/forms/basic-inputs.html
fast/forms/input-disabled-color.html
fast/forms/search/search-size-with-decorations.html
http/tests/navigation/javascriptlink-frames.html

Comment 9 Build Bot 2015-02-27 16:33:18 PST

Created attachment 247574 [details]
Archive of layout-test-results from ews107 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5

Comment 10 zalan 2015-02-27 20:10:10 PST

Created attachment 247585 [details]
Patch

Comment 11 WebKit Commit Bot 2015-02-27 22:21:26 PST

Comment on attachment 247585 [details]
Patch

Clearing flags on attachment: 247585

Committed r180815: <http://trac.webkit.org/changeset/180815>

Comment 12 WebKit Commit Bot 2015-02-27 22:21:32 PST

All reviewed patches have been landed.  Closing bug.