| Summary: | bmalloc: Refactored SegregatedFreeList and BoundaryTag::init | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Geoffrey Garen <ggaren> | ||||
| Component: | New Bugs | Assignee: | Geoffrey Garen <ggaren> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | andersca, commit-queue, ossy | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Geoffrey Garen
2015-02-26 11:48:33 PST
Created attachment 247435 [details]
Patch
Attachment 247435 [details] did not pass style-queue:
ERROR: Source/bmalloc/bmalloc/VMHeap.cpp:26: Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
ERROR: Source/bmalloc/bmalloc/FreeList.cpp:26: Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
ERROR: Source/bmalloc/bmalloc/FreeList.cpp:28: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
Total errors found: 3 in 9 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Committed r180693: <http://trac.webkit.org/changeset/180693> (In reply to comment #3) > Committed r180693: <http://trac.webkit.org/changeset/180693> mac build fixed by http://trac.webkit.org/changeset/180694 (In reply to comment #3) > Committed r180693: <http://trac.webkit.org/changeset/180693> cmake build fixed by http://trac.webkit.org/changeset/180695 Just out of curiosity, why is it funny to break the build, because you don't have 5-10 minutes for EWS bots? And one more question: Is the WK2 owner model is valid from the brand new bmalloc too? If no, please don't break the build. Thanks. |