Bug 142044

Summary:

[FreeType] REGRESSION(r180563): Introduced crashes

Product:

WebKit

Reporter:

Michael Catanzaro <mcatanzaro>

Component:

WebCore Misc.

Assignee:

Michael Catanzaro <mcatanzaro>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, mcatanzaro, mmaxfield, mrobinson, zan

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Linux

Attachments:

Description	Flags
Patch	none

Michael Catanzaro

Reported 2015-02-26 06:37:22 PST

Zan noticed the following after r180563: > Source/WebCore/platform/graphics/freetype/FontPlatformDataFreeType.cpp:307 > - cairo_font_options_t* options = getDefaultFontOptions(); > + cairo_font_options_t* options = getDefaultCairoFontOptions(); > + FcPattern* optionsPattern = m_pattern ? m_pattern.get() : getDefaultFontconfigOptions(); > + setCairoFontOptionsFromFontConfigPattern(options, optionsPattern); This properly checks for and works around the possibly-null m_pattern ... > Source/WebCore/platform/graphics/freetype/FontPlatformDataFreeType.cpp:324 > + for (int i = 0; FcPatternGetMatrix(m_pattern.get(), FC_MATRIX, i, &tempFontConfigMatrix) == FcResultMatch; i++) > + FcMatrixMultiply(&fontConfigMatrix, &fontConfigMatrix, tempFontConfigMatrix); ... but this doesn't anymore (though it used to), which leads to crashes. It should be using optionsPattern rather than m_pattern.

Attachments
Patch (2.46 KB, patch) 2015-02-26 07:30 PST, Michael Catanzaro	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Michael Catanzaro

Comment 1 2015-02-26 07:30:50 PST

Created attachment 247426 [details] Patch

WebKit Commit Bot

Comment 2 2015-02-26 08:24:59 PST

Comment on attachment 247426 [details] Patch Clearing flags on attachment: 247426 Committed r180675: <http://trac.webkit.org/changeset/180675>

WebKit Commit Bot

Comment 3 2015-02-26 08:25:03 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.