Summary: | [EFL][GTK] REGRESSION(180602): It made fast/workers test timeout | ||
---|---|---|---|
Product: | WebKit | Reporter: | Csaba Osztrogonác <ossy> |
Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> |
Status: | RESOLVED FIXED | ||
Severity: | Critical | CC: | cgarcia, chavarria1991, clopez, gyuyoung.kim, mark.lam, msaboff, ossy |
Priority: | P1 | ||
Version: | 528+ (Nightly build) | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Bug Depends on: | |||
Bug Blocks: | 141990 |
Description
Csaba Osztrogonác
2015-02-26 02:41:59 PST
I skipped fast/workers tests on EFL bots, because it increased the testing time from 15 minutes to 35 minutes, and then the bot died with timeout. Skip landed in http://trac.webkit.org/changeset/180671 . One of the side effects of r180602 is that it results in more threads being scanned by GC. Specifically, that means a VM on the main thread will also scan the stacks of all worker threads because they have had a VM run on them before. This means they are doing more work, though we had anticipated that it shouldn’t be that costly. I’ll prepare a test patch to see if eliminating / reducing this unnecessary work makes a difference. FYI, the r180602 patch was rolled out in r180690: <http://trac.webkit.org/r180690>. With the solution for https://bugs.webkit.org/show_bug.cgi?id=141990, the GTK test bot seems to be happy. The previously skipped tests have been un-skipped when I rolled out r180690 earlier. Nothing more to do. Closing this bug. |