Bug 142028

Summary:

Cache glyph widths to GlyphPages

Product:

WebKit

Reporter:

Antti Koivisto <koivisto>

Component:

Layout and Rendering

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED WONTFIX

Severity:

Normal

CC:

bfulgham, buildbot, commit-queue, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

142098, 142756

Bug Blocks:

Attachments:

Description	Flags
patch	none
Archive of layout-test-results from ews105 for mac-mavericks-wk2	none
Archive of layout-test-results from ews101 for mac-mavericks	none
another	none
another	none
another	none
another	none
fix svg fonts	none
another	none

Antti Koivisto

Reported 2015-02-25 15:58:33 PST

We can remove one cache layer and speed up WidthIterator by doing less hash lookups.

Attachments
patch (22.60 KB, patch) 2015-02-25 16:13 PST, Antti Koivisto	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews105 for mac-mavericks-wk2 (846.95 KB, application/zip) 2015-02-25 16:53 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews101 for mac-mavericks (683.92 KB, application/zip) 2015-02-25 17:10 PST, Build Bot	no flags	Details
another (24.34 KB, patch) 2015-02-27 05:22 PST, Antti Koivisto	no flags	Details Formatted Diff Diff
another (24.13 KB, patch) 2015-02-27 05:58 PST, Antti Koivisto	no flags	Details Formatted Diff Diff
another (24.13 KB, patch) 2015-02-27 06:52 PST, Antti Koivisto	no flags	Details Formatted Diff Diff
another (24.09 KB, patch) 2015-02-27 07:22 PST, Antti Koivisto	no flags	Details Formatted Diff Diff
fix svg fonts (25.85 KB, patch) 2015-03-13 15:40 PDT, Antti Koivisto	no flags	Details Formatted Diff Diff
another (25.10 KB, patch) 2015-03-13 15:53 PDT, Antti Koivisto	no flags	Details Formatted Diff Diff
Show Obsolete (8) View All Add attachment proposed patch, testcase, etc.

Antti Koivisto

Comment 1 2015-02-25 16:13:39 PST

Created attachment 247360 [details] patch

Andreas Kling

Comment 2 2015-02-25 16:20:13 PST

Comment on attachment 247360 [details] patch r=me

Build Bot

Comment 3 2015-02-25 16:53:41 PST

Comment on attachment 247360 [details] patch Attachment 247360 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5277609701146624 New failing tests: fast/text/wide-zero-width-space.html mathml/opentype/opentype-stretchy-horizontal.html mathml/opentype/opentype-stretchy.html

Build Bot

Comment 4 2015-02-25 16:53:43 PST

Created attachment 247365 [details] Archive of layout-test-results from ews105 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5

Build Bot

Comment 5 2015-02-25 17:10:15 PST

Comment on attachment 247360 [details] patch Attachment 247360 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/4698514428788736 New failing tests: fast/text/wide-zero-width-space.html mathml/opentype/opentype-stretchy-horizontal.html mathml/opentype/opentype-stretchy.html

Build Bot

Comment 6 2015-02-25 17:10:17 PST

Created attachment 247369 [details] Archive of layout-test-results from ews101 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-mavericks Platform: Mac OS X 10.9.5

Antti Koivisto

Comment 7 2015-02-27 05:22:02 PST

Created attachment 247509 [details] another

Antti Koivisto

Comment 8 2015-02-27 05:58:52 PST

Created attachment 247510 [details] another

Antti Koivisto

Comment 9 2015-02-27 06:52:05 PST

Created attachment 247511 [details] another

Antti Koivisto

Comment 10 2015-02-27 07:22:07 PST

Created attachment 247512 [details] another

WebKit Commit Bot

Comment 11 2015-02-27 08:12:33 PST

Comment on attachment 247512 [details] another Clearing flags on attachment: 247512 Committed r180752: <http://trac.webkit.org/changeset/180752>

WebKit Commit Bot

Comment 12 2015-02-27 08:12:40 PST

All reviewed patches have been landed. Closing bug.

Brent Fulgham

Comment 13 2015-02-27 13:02:21 PST

This change seems to have broken several SVG tests on Windows. Could you please take a look? svg/W3C-SVG-1.1/text-altglyph-01-b.svg svg/W3C-SVG-1.1/text-text-06-t.svg svg/batik/text/xmlSpace.svg svg/custom/altglyph.svg svg/custom/glyph-selection-arabic-forms.svg svg/text/alt-glyph-for-surrogate-pair.svg svg/text/kerning.svg svg/text/multichar-glyph.svg svg/text/text-altglyph-01-b.svg svg/text/text-text-06-t.svg

Antti Koivisto

Comment 14 2015-02-27 13:24:04 PST

https://build.webkit.org/results/Apple%20Win%207%20Release%20(Tests)/r180752%20(50006)/results.html

WebKit Commit Bot

Comment 15 2015-02-27 13:38:08 PST

Re-opened since this is blocked by bug 142098

Antti Koivisto

Comment 16 2015-03-13 15:40:07 PDT

Created attachment 248613 [details] fix svg fonts

WebKit Commit Bot

Comment 17 2015-03-13 15:41:28 PDT

Attachment 248613 [details] did not pass style-queue: ERROR: Source/WebCore/Configurations/FeatureDefines.xcconfig:0: Any changes made to FeatureDefines should be made to all of them (changed file does not match Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig). [featuredefines/equality] [5] ERROR: Source/WebCore/Configurations/FeatureDefines.xcconfig:0: Any changes made to FeatureDefines should be made to all of them (changed file does not match Source/WebKit/mac/Configurations/FeatureDefines.xcconfig). [featuredefines/equality] [5] ERROR: Source/WebCore/Configurations/FeatureDefines.xcconfig:0: Any changes made to FeatureDefines should be made to all of them (changed file does not match Source/WebKit2/Configurations/FeatureDefines.xcconfig). [featuredefines/equality] [5] Total errors found: 3 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.

Antti Koivisto

Comment 18 2015-03-13 15:53:28 PDT

Created attachment 248614 [details] another

WebKit Commit Bot

Comment 19 2015-03-13 18:11:26 PDT

Comment on attachment 248614 [details] another Clearing flags on attachment: 248614 Committed r181492: <http://trac.webkit.org/changeset/181492>

WebKit Commit Bot

Comment 20 2015-03-13 18:11:33 PDT

All reviewed patches have been landed. Closing bug.

WebKit Commit Bot

Comment 21 2015-03-16 16:52:11 PDT

Re-opened since this is blocked by bug 142756

Csaba Osztrogonác

Comment 22 2015-09-14 11:19:24 PDT

Comment on attachment 247360 [details] patch Cleared Andreas Kling's review+ from obsolete attachment 247360 [details] so that this bug does not appear in http://webkit.org/pending-commit.

Antti Koivisto

Comment 23 2015-09-14 14:04:53 PDT

Glyph mappings are per typeface while widths are per font (size included). Lets not do this as it would complicate future optimizations.

Note You need to log in before you can comment on or make changes to this bug.