| Summary: | Cache glyph widths to GlyphPages | ||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Antti Koivisto <koivisto> | ||||||||||||||||||||
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> | ||||||||||||||||||||
| Status: | RESOLVED WONTFIX | ||||||||||||||||||||||
| Severity: | Normal | CC: | bfulgham, buildbot, commit-queue, rniwa | ||||||||||||||||||||
| Priority: | P2 | ||||||||||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||||||
| Bug Depends on: | 142098, 142756 | ||||||||||||||||||||||
| Bug Blocks: | |||||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||||
|
Description
Antti Koivisto
2015-02-25 15:58:33 PST
Created attachment 247360 [details]
patch
Comment on attachment 247360 [details]
patch
r=me
Comment on attachment 247360 [details] patch Attachment 247360 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5277609701146624 New failing tests: fast/text/wide-zero-width-space.html mathml/opentype/opentype-stretchy-horizontal.html mathml/opentype/opentype-stretchy.html Created attachment 247365 [details]
Archive of layout-test-results from ews105 for mac-mavericks-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Comment on attachment 247360 [details] patch Attachment 247360 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/4698514428788736 New failing tests: fast/text/wide-zero-width-space.html mathml/opentype/opentype-stretchy-horizontal.html mathml/opentype/opentype-stretchy.html Created attachment 247369 [details]
Archive of layout-test-results from ews101 for mac-mavericks
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101 Port: mac-mavericks Platform: Mac OS X 10.9.5
Created attachment 247509 [details]
another
Created attachment 247510 [details]
another
Created attachment 247511 [details]
another
Created attachment 247512 [details]
another
Comment on attachment 247512 [details] another Clearing flags on attachment: 247512 Committed r180752: <http://trac.webkit.org/changeset/180752> All reviewed patches have been landed. Closing bug. This change seems to have broken several SVG tests on Windows. Could you please take a look? svg/W3C-SVG-1.1/text-altglyph-01-b.svg svg/W3C-SVG-1.1/text-text-06-t.svg svg/batik/text/xmlSpace.svg svg/custom/altglyph.svg svg/custom/glyph-selection-arabic-forms.svg svg/text/alt-glyph-for-surrogate-pair.svg svg/text/kerning.svg svg/text/multichar-glyph.svg svg/text/text-altglyph-01-b.svg svg/text/text-text-06-t.svg Re-opened since this is blocked by bug 142098 Created attachment 248613 [details]
fix svg fonts
Attachment 248613 [details] did not pass style-queue:
ERROR: Source/WebCore/Configurations/FeatureDefines.xcconfig:0: Any changes made to FeatureDefines should be made to all of them (changed file does not match Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig). [featuredefines/equality] [5]
ERROR: Source/WebCore/Configurations/FeatureDefines.xcconfig:0: Any changes made to FeatureDefines should be made to all of them (changed file does not match Source/WebKit/mac/Configurations/FeatureDefines.xcconfig). [featuredefines/equality] [5]
ERROR: Source/WebCore/Configurations/FeatureDefines.xcconfig:0: Any changes made to FeatureDefines should be made to all of them (changed file does not match Source/WebKit2/Configurations/FeatureDefines.xcconfig). [featuredefines/equality] [5]
Total errors found: 3 in 13 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 248614 [details]
another
Comment on attachment 248614 [details] another Clearing flags on attachment: 248614 Committed r181492: <http://trac.webkit.org/changeset/181492> All reviewed patches have been landed. Closing bug. Re-opened since this is blocked by bug 142756 Comment on attachment 247360 [details] patch Cleared Andreas Kling's review+ from obsolete attachment 247360 [details] so that this bug does not appear in http://webkit.org/pending-commit. Glyph mappings are per typeface while widths are per font (size included). Lets not do this as it would complicate future optimizations. |