Bug 141989

Summary: CMake build of libllvmForJSC.so should limit its export list like the Xcode build does
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Filip Pizlo
Reported 2015-02-24 15:29:00 PST
Our Xcode build of libllvmForJSC.dylib only exports one symbol. This protects our LLVM instance from having any interaction with other LLVMs that might be linked by the client. We do it in Configurations/LLVMForJSC.xcconfig: OTHER_LDFLAGS_HIDE_SYMBOLS = -Wl,-exported_symbol -Wl,_initializeAndGetJSCLLVMAPI -Wl,-all_load; Looking at libllvmForJSC.so, it's clear that it's exporting the world. I just did an nm on it and there are many symbols with uppercase letter codes, indicating that they are global.
Attachments
Patch (2.95 KB, patch)
2015-02-24 20:49 PST, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
Patch (1.75 KB, patch)
2015-02-24 20:49 PST, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2015-02-24 20:49:08 PST
Created attachment 247303 [details] Patch
Filip Pizlo
Comment 2 2015-02-24 20:49:55 PST
Created attachment 247304 [details] Patch
Gyuyoung Kim
Comment 3 2015-02-24 22:15:07 PST
Comment on attachment 247304 [details] Patch LGTM
WebKit Commit Bot
Comment 4 2015-02-24 23:00:12 PST
Comment on attachment 247304 [details] Patch Clearing flags on attachment: 247304 Committed r180618: <http://trac.webkit.org/changeset/180618>
WebKit Commit Bot
Comment 5 2015-02-24 23:00:16 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.