| Summary: | Web Inspector: Right/Left arrow no longer works in console to expand/collapse ObjectTrees | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||
| Component: | Web Inspector | Assignee: | Joseph Pecoraro <joepeck> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
Created attachment 255460 [details]
[PATCH] Proposed Fix
Comment on attachment 255460 [details] [PATCH] Proposed Fix Clearing flags on attachment: 255460 Committed r185911: <http://trac.webkit.org/changeset/185911> All reviewed patches have been landed. Closing bug. |
* SUMMARY Right/Left arrow no longer works in console to expand/collapse ObjectTrees. * NOTES UserInterface/Views/LogContentView.js _leftArrowWasPressed/_rightArrowWasPressed are reaching into the DOM to get "Sections" instead of using model objects. // FIXME: This no longer works with ObjectTrees. This should be smarter and not reach into the DOM. var outlineSection = currentMessage.querySelector(".console-formatted-object > .section"); if (outlineSection) outlineSection._section.collapse(); Ideally this would go through ConsoleMessage -> if ObjectTree -> expand/collapse