Bug 141949

Summary: Web Inspector: Right/Left arrow no longer works in console to expand/collapse ObjectTrees
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2015-02-23 19:48:51 PST
* SUMMARY Right/Left arrow no longer works in console to expand/collapse ObjectTrees. * NOTES UserInterface/Views/LogContentView.js _leftArrowWasPressed/_rightArrowWasPressed are reaching into the DOM to get "Sections" instead of using model objects. // FIXME: This no longer works with ObjectTrees. This should be smarter and not reach into the DOM. var outlineSection = currentMessage.querySelector(".console-formatted-object > .section"); if (outlineSection) outlineSection._section.collapse(); Ideally this would go through ConsoleMessage -> if ObjectTree -> expand/collapse
Attachments
[PATCH] Proposed Fix (8.26 KB, patch)
2015-06-23 18:02 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-02-23 19:49:16 PST
<rdar://problem/19933075>
Joseph Pecoraro
Comment 2 2015-06-23 18:02:03 PDT
Created attachment 255460 [details] [PATCH] Proposed Fix
WebKit Commit Bot
Comment 3 2015-06-24 08:33:22 PDT
Comment on attachment 255460 [details] [PATCH] Proposed Fix Clearing flags on attachment: 255460 Committed r185911: <http://trac.webkit.org/changeset/185911>
WebKit Commit Bot
Comment 4 2015-06-24 08:33:24 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.