Bug 141944 – Always serialize :lang()'s arguments to strings

• Component: New Bugs
• Status: RESOLVED FIXED

[Dhi Aurrahman]

Always serialize :lang()'s arguments to strings

[Dhi Aurrahman]

Created attachment 247181 [details]
Patch

[Build Bot]

Comment on attachment 247181 [details]
Patch

Attachment 247181 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5735819260198912

New failing tests:
fast/css/parsing-css-lang.html
fast/dom/css-selectorText.html

[Build Bot]

Created attachment 247184 [details]
Archive of layout-test-results from ews104 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5

[Dhi Aurrahman]

Created attachment 247190 [details]
Patch

[Dhi Aurrahman]

Created attachment 247204 [details]
Patch

[Benjamin Poulain]

Comment on attachment 247204 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=247204&action=review

> LayoutTests/fast/css/css-lang-selector-with-string-arguments-text.html:32
> +    args = args[1].split(/\s*,\s*/);

Neat! I never thought of using split() this way.

> LayoutTests/fast/css/css-selector-text.html:28
> +    var args = /\(([^)]+)/.exec(selector);

This is a bit fragile for css-selector-text.html

You could have ":matches(foo, bar):lang(foo, bar):lang(foo)".

Ideally you should have matching group over ":lang(...)", go over each one and do the conversion below.
It would probably be fine to just change /\(([^)]+)/ to /:lang\(([^)]+)/, cases with multiple :lang() can be handled outside this file.

> LayoutTests/fast/css/css-set-selector-text.html:31
> +function expectedSerializedLangSelector(selector)

ditto.

[Dhi Aurrahman]

Created attachment 247223 [details]
Patch

[Dhi Aurrahman]

(In reply to comment #6)
> Comment on attachment 247204 [details]
> Patch
> 
> View in context:

> Ideally you should have matching group over ":lang(...)", go over each one
> and do the conversion below.
> It would probably be fine to just change /\(([^)]+)/ to /:lang\(([^)]+)/,
> cases with multiple :lang() can be handled outside this file.
> 
> > LayoutTests/fast/css/css-set-selector-text.html:31
> > +function expectedSerializedLangSelector(selector)
> 
> ditto.

I will add tests for multiple (pseudo) selectors after this patch. The current patch guards the arguments `parser` with suggested /:lang\(([^)]+)/ expression.

[Dhi Aurrahman]

Created attachment 247226 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 247226 [details]
Patch for landing

Rejecting attachment 247226 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 247226, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in LayoutTests/ChangeLog contains OOPS!.

Full output: http://webkit-queues.appspot.com/results/5754843817836544

[Dhi Aurrahman]

Created attachment 247228 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 247228 [details]
Patch for landing

Clearing flags on attachment: 247228

Committed r180558: <http://trac.webkit.org/changeset/180558>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.