| Summary: | Merge run-launcher into run-minibrowser | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Carlos Alberto Lopez Perez <clopez> | ||||
| Component: | Tools / Tests | Assignee: | Csaba Osztrogonác <ossy> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | andersca, cgarcia, commit-queue, dbates, ddkilzer, glenn, mcatanzaro, ossy, sam | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Carlos Alberto Lopez Perez
2015-02-23 15:08:44 PST
Yes, it seems it is Mac only now. But run-launcher already works, you can copy/paste the logic from it. What is it used for? will it replace run-launcher eventually? I didn't knew about run-launcher. Until now I'm executing the minibrowser manually like: Tools/jhbuild/jhbuild-wrapper --gtk run WebKitBuild/Release/bin/MiniBrowser What is the difference between run-launcher and run-minibrowser ? Should we merge both ? It seems run-launcher is used only EFL and GTK nowadays, run-webkit-tests calls it after tests (efl.py, gtk.py) And run-minibrowser seems to be Mac only script now. I'd prefer merging run-launcher to run-minibrowser. Be sure to update the build-webkit script as well; it instructs users to use run-launcher without any arguments when the build is complete, but that just prints a message saying your OS is unsupported, so this would be a good time to fix that. Created attachment 251741 [details]
Patch
additionally removing obsolete FIXMEs
Comment on attachment 251741 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=251741&action=review > Tools/Scripts/webkitpy/port/efl.py:-132 > - # FIXME: We should find a way to share this implmentation with Gtk, > - # or teach run-launcher how to call run-safari and move this down to WebKitPort. It is only a oneliner, there is no need to try to share it with GTK. > Tools/Scripts/webkitpy/port/efl.py:-135 > - # FIXME: old-run-webkit-tests also added ["-graphicssystem", "raster", "-style", "windows"] > - # FIXME: old-run-webkit-tests converted results_filename path for cygwin. Just some comment, why can we remove them: - -graphicssystem raster -style windows are Qt crufts - cygwin: I can't remember if we ever supported Windows. Comment on attachment 251741 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=251741&action=review > Tools/Scripts/webkitpy/port/efl.py:131 > + self._run_script("run-minibrowser", ["file://%s" % results_filename]) This is not the right way to construct a URL from a local file name. Isn’t there some python library function that can turn a filename into a URL that can handle things like "%" characters? > Tools/Scripts/webkitpy/port/gtk.py:202 > + self._run_script("run-minibrowser", ["file://%s" % results_filename]) Ditto. webkitpy.common.system.path.abspath_to_uri does it, win.py already use it in its show_results_html_file. The results is same, but I'll change it before landing. Committed r183400: <http://trac.webkit.org/changeset/183400> |