Bug 141889

Summary:

Bot watcher's dashboard sometimes hits an assertion: data.num_missing === this.layoutTestResults.testsWithMissingResults.length

Product:

WebKit

Reporter:

Alexey Proskuryakov <ap>

Component:

Tools / Tests

Assignee:

Alexey Proskuryakov <ap>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, thorton, timothy

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
proposed fix	none

Description Alexey Proskuryakov 2015-02-22 22:30:01 PST

data.num_missing count includes tests that only had missing pixel results on retry (e.g. "TEXT MISSING"). The overall outcome for such tests is of course REGRESSION, and not MISSING, so we don't include them in layoutTestResults.testsWithMissingResults, and probably shouldn't.

Comment 1 Alexey Proskuryakov 2015-02-22 22:31:28 PST

Created attachment 247099 [details]
proposed fix

Comment 2 WebKit Commit Bot 2015-02-24 20:33:07 PST

Comment on attachment 247099 [details]
proposed fix

Clearing flags on attachment: 247099

Committed r180611: <http://trac.webkit.org/changeset/180611>

Comment 3 WebKit Commit Bot 2015-02-24 20:33:10 PST

All reviewed patches have been landed.  Closing bug.