Bug 141866

Summary: Black line across screen on Adobe Illustrator detail page (non-retina only)
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, esprehn+autocc, glenn, kondapallykalyan, rniwa, zalan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Screenshot
none
Test reduction
none
Patch
none
Archive of layout-test-results from ews100 for mac-mavericks
none
Archive of layout-test-results from ews106 for mac-mavericks-wk2
none
Patch none

Description Myles C. Maxfield 2015-02-21 10:32:27 PST
https://www.adobe.com/products/illustrator.html

Version 8.0.3 (10600.3.18, r180475)
14C109
Comment 1 Myles C. Maxfield 2015-02-21 10:34:02 PST
Created attachment 247049 [details]
Screenshot
Comment 2 zalan 2015-02-23 12:24:48 PST
Created attachment 247135 [details]
Test reduction
Comment 3 zalan 2015-02-25 15:44:36 PST
Created attachment 247355 [details]
Patch
Comment 4 Tim Horton 2015-02-25 15:46:10 PST
Comment on attachment 247355 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=247355&action=review

> Source/WebCore/rendering/RenderBoxModelObject.cpp:1164
> +        phase.setWidth(tileSize.width() ? tileSize.width() - fmodf(computedXPosition + left, tileSize.width()): 0);

space before the colon, while you're fixing style
Comment 5 Build Bot 2015-02-25 16:01:53 PST
Comment on attachment 247355 [details]
Patch

Attachment 247355 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6025092387569664

New failing tests:
fast/backgrounds/hidpi-bitmap-background-repeat-on-subpixel-position.html
Comment 6 Build Bot 2015-02-25 16:01:56 PST
Created attachment 247358 [details]
Archive of layout-test-results from ews100 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-mavericks  Platform: Mac OS X 10.9.5
Comment 7 Build Bot 2015-02-25 16:38:55 PST
Comment on attachment 247355 [details]
Patch

Attachment 247355 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6606028053413888

New failing tests:
fast/backgrounds/hidpi-bitmap-background-repeat-on-subpixel-position.html
Comment 8 Build Bot 2015-02-25 16:38:58 PST
Created attachment 247363 [details]
Archive of layout-test-results from ews106 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5
Comment 9 zalan 2015-02-25 20:52:39 PST
Created attachment 247400 [details]
Patch
Comment 10 WebKit Commit Bot 2015-02-25 22:56:20 PST
Comment on attachment 247400 [details]
Patch

Clearing flags on attachment: 247400

Committed r180661: <http://trac.webkit.org/changeset/180661>
Comment 11 WebKit Commit Bot 2015-02-25 22:56:26 PST
All reviewed patches have been landed.  Closing bug.