Bug 141852

Summary: API::String should just be a simple wrapper for WTF strings
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, cgarcia, clopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch bdakin: review+

Anders Carlsson
Reported 2015-02-20 12:52:08 PST
API::String should just be a simple wrapper for WTF strings
Attachments
Patch (6.38 KB, patch)
2015-02-20 12:52 PST, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (6.48 KB, patch)
2015-02-20 12:54 PST, Anders Carlsson 		bdakin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2015-02-20 12:52:57 PST
Created attachment 246989 [details] Patch
Anders Carlsson
Comment 2 2015-02-20 12:54:47 PST
Created attachment 246990 [details] Patch
Anders Carlsson
Comment 3 2015-02-20 13:09:25 PST
Committed r180449: <http://trac.webkit.org/changeset/180449>
Carlos Alberto Lopez Perez
Comment 4 2015-02-20 14:58:52 PST
(In reply to comment #3) > Committed r180449: <http://trac.webkit.org/changeset/180449> This broke the GTK build: https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Build%29/builds/55778/steps/compile-webkit/logs/stdio Last 500 characters of output: quest.cpp.o -c ../../Source/WebKit2/UIProcess/API/gtk/WebKitFileChooserRequest.cpp ../../Source/WebKit2/UIProcess/API/gtk/WebKitFileChooserRequest.cpp: In function 'const gchar* const* webkit_file_chooser_request_get_selected_files(WebKitFileChooserRequest*)': ../../Source/WebKit2/UIProcess/API/gtk/WebKitFileChooserRequest.cpp:357:26: error: 'class API::String' has no member named 'isEmpty' if (webFileName->isEmpty()) ^
Carlos Alberto Lopez Perez
Comment 5 2015-02-20 17:49:10 PST
(In reply to comment #4) > (In reply to comment #3) > > Committed r180449: <http://trac.webkit.org/changeset/180449> > > This broke the GTK build: > > https://build.webkit.org/builders/GTK%20Linux%2064- > bit%20Release%20%28Build%29/builds/55778/steps/compile-webkit/logs/stdio > > Last 500 characters of output: > quest.cpp.o -c > ../../Source/WebKit2/UIProcess/API/gtk/WebKitFileChooserRequest.cpp > ../../Source/WebKit2/UIProcess/API/gtk/WebKitFileChooserRequest.cpp: In > function 'const gchar* const* > webkit_file_chooser_request_get_selected_files(WebKitFileChooserRequest*)': > ../../Source/WebKit2/UIProcess/API/gtk/WebKitFileChooserRequest.cpp:357:26: > error: 'class API::String' has no member named 'isEmpty' > if (webFileName->isEmpty()) > ^ Build fix landed in r180469 <https://trac.webkit.org/r180469>
Note You need to log in before you can comment on or make changes to this bug.