Bug 141836

Summary: [WK2][EFL] Fix the build after r180362
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: WebKit EFLAssignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, lucas.de.marchi, ossy, zan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 141813    
Bug Blocks: 141808    
Attachments:
Description Flags
WIP
none
WIP
none
Patch
none
Patch none

Description Gyuyoung Kim 2015-02-20 03:23:30 PST 
r180409 fixed GTK port though, EFL port is still broken.
Comment 1 Gyuyoung Kim 2015-02-20 03:34:53 PST 
Created attachment 246959 [details]
WIP
Comment 2 Gyuyoung Kim 2015-02-20 03:50:28 PST 
Created attachment 246960 [details]
WIP
Comment 3 Gyuyoung Kim 2015-02-20 05:00:24 PST 
Created attachment 246963 [details]
Patch
Comment 4 Carlos Garcia Campos 2015-02-20 05:03:04 PST 
Comment on attachment 246963 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=246963&action=review

> Source/WebKit2/UIProcess/API/C/efl/WKAPICastEfl.h:115
> +inline WKPopupMenuListenerRef toAPI(WebPopupMenuListenerEfl* popup)
> +{
> +    return static_cast<WKPopupMenuListenerRef>(static_cast<void*>(popup));
> +}
> +
> +inline WebPopupMenuListenerEfl* toImpl(WKPopupMenuListenerRef popupRef)
> +{
> +    return static_cast<WebPopupMenuListenerEfl*>(static_cast<void*>(const_cast<OpaqueWKPopupMenuListener*>(popupRef)));
> +}

I wonder why you need this, isn't WebPopupMenuListenerEfl an API::Object?
Comment 5 Gyuyoung Kim 2015-02-20 05:08:11 PST 
Comment on attachment 246963 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=246963&action=review

>> Source/WebKit2/UIProcess/API/C/efl/WKAPICastEfl.h:115
>> +}
> 
> I wonder why you need this, isn't WebPopupMenuListenerEfl an API::Object?

Yes, it is not API::Object yet.

http://trac.webkit.org/browser/trunk/Source/WebKit2/UIProcess/efl/WebPopupMenuListenerEfl.h#L33
Comment 6 Carlos Garcia Campos 2015-02-20 05:11:18 PST 
(In reply to comment #5)
> Comment on attachment 246963 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=246963&action=review
> 
> >> Source/WebKit2/UIProcess/API/C/efl/WKAPICastEfl.h:115
> >> +}
> > 
> > I wonder why you need this, isn't WebPopupMenuListenerEfl an API::Object?
> 
> Yes, it is not API::Object yet.
> 
> http://trac.webkit.org/browser/trunk/Source/WebKit2/UIProcess/efl/
> WebPopupMenuListenerEfl.h#L33

Ok, then I guess you should add template specialization, like Zan suggested in the GTK+ patch
Comment 7 Gyuyoung Kim 2015-02-20 05:23:18 PST 
Created attachment 246966 [details]
Patch
Comment 8 Gyuyoung Kim 2015-02-20 06:29:05 PST 
Comment on attachment 246966 [details]
Patch

Clearing flags on attachment: 246966

Committed r180411: <http://trac.webkit.org/changeset/180411>
Comment 9 Gyuyoung Kim 2015-02-20 06:29:12 PST 
All reviewed patches have been landed.  Closing bug.