Summary: | WebsiteDataStore should ensure that local storage is written before exiting | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Anders Carlsson <andersca> | ||||
Component: | New Bugs | Assignee: | Anders Carlsson <andersca> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | cgarcia, clopez, commit-queue, gyuyoung.kim, ossy | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Anders Carlsson
2015-02-19 10:06:16 PST
Created attachment 246895 [details]
Patch
Attachment 246895 [details] did not pass style-queue:
ERROR: Source/WebKit2/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:56: Place brace on its own line for function definitions. [whitespace/braces] [4]
Total errors found: 1 in 5 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Committed r180349: <http://trac.webkit.org/changeset/180349> (In reply to comment #3) > Committed r180349: <http://trac.webkit.org/changeset/180349> non Cocoa buildfix landed in http://trac.webkit.org/changeset/180350, I only added empty functions to fix the build, but I have no idea if EFL/GTK use this code or not, should add platform specific implemenation or not. Please let us know if we have to do something. |