Bug 141798

Summary: WebsiteDataStore should ensure that local storage is written before exiting
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, clopez, commit-queue, gyuyoung.kim, ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch sam: review+

Anders Carlsson
Reported 2015-02-19 10:06:16 PST
WebsiteDataStore should ensure that local storage is written before exiting
Attachments
Patch (10.42 KB, patch)
2015-02-19 10:07 PST, Anders Carlsson 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2015-02-19 10:07:27 PST
Created attachment 246895 [details] Patch
WebKit Commit Bot
Comment 2 2015-02-19 10:09:43 PST
Attachment 246895 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:56: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Anders Carlsson
Comment 3 2015-02-19 10:46:10 PST
Committed r180349: <http://trac.webkit.org/changeset/180349>
Csaba Osztrogonác
Comment 4 2015-02-19 11:26:13 PST
(In reply to comment #3) > Committed r180349: <http://trac.webkit.org/changeset/180349> non Cocoa buildfix landed in http://trac.webkit.org/changeset/180350, I only added empty functions to fix the build, but I have no idea if EFL/GTK use this code or not, should add platform specific implemenation or not. Please let us know if we have to do something.
Note You need to log in before you can comment on or make changes to this bug.