Bug 141797

Summary:

Move WorkQueue from WK2 to WTF

Product:

WebKit

Reporter:

Antti Koivisto <koivisto>

Component:

Platform

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, commit-queue, ossy

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	andersca: review+
another	none
another	none
another	none
another	none
another	none

Antti Koivisto

Reported 2015-02-19 06:58:36 PST

It might be useful in WebCore.

Attachments
patch (56.93 KB, patch) 2015-02-19 07:14 PST, Antti Koivisto	andersca: review+	Details Formatted Diff Diff
another (57.37 KB, patch) 2015-02-20 02:28 PST, Antti Koivisto	no flags	Details Formatted Diff Diff
another (57.41 KB, patch) 2015-02-20 04:12 PST, Antti Koivisto	no flags	Details Formatted Diff Diff
another (57.89 KB, patch) 2015-02-20 05:08 PST, Antti Koivisto	no flags	Details Formatted Diff Diff
another (58.60 KB, patch) 2015-02-20 05:17 PST, Antti Koivisto	no flags	Details Formatted Diff Diff
another (58.58 KB, patch) 2015-02-20 05:25 PST, Antti Koivisto	no flags	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Antti Koivisto

Comment 1 2015-02-19 07:14:41 PST

Created attachment 246891 [details] patch

WebKit Commit Bot

Comment 2 2015-02-19 07:17:08 PST

Attachment 246891 [details] did not pass style-queue: ERROR: Source/WTF/wtf/WorkQueue.h:72: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/WorkQueue.h:73: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/WorkQueue.h:78: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/WorkQueue.h:81: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/efl/WorkQueueEfl.cpp:37: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/efl/WorkQueueEfl.cpp:55: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/efl/WorkQueueEfl.cpp:63: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/gtk/WorkQueueGtk.cpp:56: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WTF/wtf/gtk/WorkQueueGtk.cpp:76: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/gtk/WorkQueueGtk.cpp:81: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/wtf/gtk/WorkQueueGtk.cpp:103: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/gtk/WorkQueueGtk.cpp:107: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WTF/wtf/gtk/WorkQueueGtk.cpp:110: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/gtk/WorkQueueGtk.cpp:114: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WTF/wtf/cocoa/WorkQueueCocoa.cpp:31: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/cocoa/WorkQueueCocoa.cpp:40: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 16 in 18 files If any of these errors are false positives, please file a bug against check-webkit-style.

Anders Carlsson

Comment 3 2015-02-19 13:45:17 PST

Comment on attachment 246891 [details] patch r=me if you fix the build.

Antti Koivisto

Comment 4 2015-02-20 02:28:02 PST

Created attachment 246952 [details] another

WebKit Commit Bot

Comment 5 2015-02-20 02:30:03 PST

Attachment 246952 [details] did not pass style-queue: ERROR: Source/WTF/wtf/WorkQueue.h:68: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/WorkQueue.h:69: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/WorkQueue.h:74: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/WorkQueue.h:77: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/efl/WorkQueueEfl.cpp:37: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/efl/WorkQueueEfl.cpp:55: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/efl/WorkQueueEfl.cpp:63: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/gtk/WorkQueueGtk.cpp:56: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WTF/wtf/gtk/WorkQueueGtk.cpp:76: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/gtk/WorkQueueGtk.cpp:81: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/wtf/gtk/WorkQueueGtk.cpp:103: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/gtk/WorkQueueGtk.cpp:107: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WTF/wtf/gtk/WorkQueueGtk.cpp:110: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/gtk/WorkQueueGtk.cpp:114: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WTF/wtf/cocoa/WorkQueueCocoa.cpp:31: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/cocoa/WorkQueueCocoa.cpp:40: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 16 in 18 files If any of these errors are false positives, please file a bug against check-webkit-style.

Antti Koivisto

Comment 6 2015-02-20 04:12:59 PST

Created attachment 246961 [details] another

WebKit Commit Bot

Comment 7 2015-02-20 04:15:09 PST

Attachment 246961 [details] did not pass style-queue: ERROR: Source/WTF/wtf/WorkQueue.h:68: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/WorkQueue.h:69: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/WorkQueue.h:74: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/WorkQueue.h:77: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/efl/WorkQueueEfl.cpp:37: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/efl/WorkQueueEfl.cpp:55: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/efl/WorkQueueEfl.cpp:63: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/gtk/WorkQueueGtk.cpp:56: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WTF/wtf/gtk/WorkQueueGtk.cpp:76: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/gtk/WorkQueueGtk.cpp:81: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/wtf/gtk/WorkQueueGtk.cpp:103: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/gtk/WorkQueueGtk.cpp:107: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WTF/wtf/gtk/WorkQueueGtk.cpp:110: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/gtk/WorkQueueGtk.cpp:114: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WTF/wtf/cocoa/WorkQueueCocoa.cpp:31: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/cocoa/WorkQueueCocoa.cpp:40: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 16 in 18 files If any of these errors are false positives, please file a bug against check-webkit-style.

Antti Koivisto

Comment 8 2015-02-20 05:08:40 PST

Created attachment 246964 [details] another

WebKit Commit Bot

Comment 9 2015-02-20 05:11:15 PST

Attachment 246964 [details] did not pass style-queue: ERROR: Source/WTF/wtf/WorkQueue.h:68: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/WorkQueue.h:69: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/WorkQueue.h:74: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/WorkQueue.h:77: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/efl/WorkQueueEfl.cpp:37: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/efl/WorkQueueEfl.cpp:55: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/efl/WorkQueueEfl.cpp:63: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/gtk/WorkQueueGtk.cpp:56: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WTF/wtf/gtk/WorkQueueGtk.cpp:76: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/gtk/WorkQueueGtk.cpp:81: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/wtf/gtk/WorkQueueGtk.cpp:103: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/gtk/WorkQueueGtk.cpp:107: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WTF/wtf/gtk/WorkQueueGtk.cpp:110: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/gtk/WorkQueueGtk.cpp:114: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WTF/wtf/cocoa/WorkQueueCocoa.cpp:31: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/cocoa/WorkQueueCocoa.cpp:40: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 16 in 18 files If any of these errors are false positives, please file a bug against check-webkit-style.

Antti Koivisto

Comment 10 2015-02-20 05:17:26 PST

Created attachment 246965 [details] another

WebKit Commit Bot

Comment 11 2015-02-20 05:20:34 PST

Attachment 246965 [details] did not pass style-queue: ERROR: Source/WTF/wtf/WorkQueue.h:68: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/WorkQueue.h:69: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/WorkQueue.h:74: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/WorkQueue.h:77: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/efl/WorkQueueEfl.cpp:37: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/efl/WorkQueueEfl.cpp:55: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/efl/WorkQueueEfl.cpp:63: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/gtk/WorkQueueGtk.cpp:58: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WTF/wtf/gtk/WorkQueueGtk.cpp:78: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/gtk/WorkQueueGtk.cpp:83: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/wtf/gtk/WorkQueueGtk.cpp:105: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/gtk/WorkQueueGtk.cpp:109: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WTF/wtf/gtk/WorkQueueGtk.cpp:112: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/gtk/WorkQueueGtk.cpp:116: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WTF/wtf/cocoa/WorkQueueCocoa.cpp:31: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/cocoa/WorkQueueCocoa.cpp:40: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 16 in 18 files If any of these errors are false positives, please file a bug against check-webkit-style.

Antti Koivisto

Comment 12 2015-02-20 05:25:12 PST

Created attachment 246967 [details] another

WebKit Commit Bot

Comment 13 2015-02-20 05:30:36 PST

Attachment 246967 [details] did not pass style-queue: ERROR: Source/WTF/wtf/WorkQueue.h:68: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/WorkQueue.h:69: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/WorkQueue.h:74: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/WorkQueue.h:77: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/efl/WorkQueueEfl.cpp:37: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/efl/WorkQueueEfl.cpp:55: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/efl/WorkQueueEfl.cpp:63: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/gtk/WorkQueueGtk.cpp:59: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WTF/wtf/gtk/WorkQueueGtk.cpp:79: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/gtk/WorkQueueGtk.cpp:84: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/wtf/gtk/WorkQueueGtk.cpp:106: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/gtk/WorkQueueGtk.cpp:110: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WTF/wtf/gtk/WorkQueueGtk.cpp:113: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/gtk/WorkQueueGtk.cpp:117: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WTF/wtf/cocoa/WorkQueueCocoa.cpp:31: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/wtf/cocoa/WorkQueueCocoa.cpp:40: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 16 in 18 files If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Commit Bot

Comment 14 2015-02-20 06:19:06 PST

Comment on attachment 246967 [details] another Clearing flags on attachment: 246967 Committed r180410: <http://trac.webkit.org/changeset/180410>

WebKit Commit Bot

Comment 15 2015-02-20 06:19:12 PST

All reviewed patches have been landed. Closing bug.

Csaba Osztrogonác

Comment 16 2015-02-20 12:02:28 PST

(In reply to comment #14) > Comment on attachment 246967 [details] > another > > Clearing flags on attachment: 246967 > > Committed r180410: <http://trac.webkit.org/changeset/180410> EFL buildfixed landed in: http://trac.webkit.org/changeset/180433 http://trac.webkit.org/changeset/180437 Unfortunalty EWS didn't notice it in time, because WK2 developers broke the EFL build.

Note You need to log in before you can comment on or make changes to this bug.