| Summary: | [Win] CFData leak in CDMSessionAVFoundationCF | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||
| Component: | WebKit Misc. | Assignee: | Brent Fulgham <bfulgham> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bfulgham, eric.carlson, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
(In reply to comment #0) > * SUMMARY > Possible CFData leak in CDMSessionAVFoundationCF. > > This looks like a leak to me: > > RetainPtr<CFDataRef> keyRequest = > AVCFAssetResourceLoadingRequestCreateStreamingContentKeyRequestDataForApp(... > ); > > The naming of the method implies "Create" so I would expect an adoptCF() > into the RetainPtr. I agree! Created attachment 246849 [details]
Patch
Comment on attachment 246849 [details]
Patch
r=me! Thanks.
Committed r180324: <http://trac.webkit.org/changeset/180324> |
* SUMMARY Possible CFData leak in CDMSessionAVFoundationCF. This looks like a leak to me: RetainPtr<CFDataRef> keyRequest = AVCFAssetResourceLoadingRequestCreateStreamingContentKeyRequestDataForApp(...); The naming of the method implies "Create" so I would expect an adoptCF() into the RetainPtr.