Bug 141765

Summary: [Win] CFData leak in CDMSessionAVFoundationCF
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: WebKit Misc.Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, eric.carlson, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch joepeck: review+

Joseph Pecoraro
Reported 2015-02-18 12:44:33 PST
* SUMMARY Possible CFData leak in CDMSessionAVFoundationCF. This looks like a leak to me: RetainPtr<CFDataRef> keyRequest = AVCFAssetResourceLoadingRequestCreateStreamingContentKeyRequestDataForApp(...); The naming of the method implies "Create" so I would expect an adoptCF() into the RetainPtr.
Attachments
Patch (1.75 KB, patch)
2015-02-18 14:36 PST, Brent Fulgham 		joepeck: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2015-02-18 14:10:39 PST
(In reply to comment #0) > * SUMMARY > Possible CFData leak in CDMSessionAVFoundationCF. > > This looks like a leak to me: > > RetainPtr<CFDataRef> keyRequest = > AVCFAssetResourceLoadingRequestCreateStreamingContentKeyRequestDataForApp(... > ); > > The naming of the method implies "Create" so I would expect an adoptCF() > into the RetainPtr. I agree!
Radar WebKit Bug Importer
Comment 2 2015-02-18 14:11:30 PST
<rdar://problem/19880286>
Brent Fulgham
Comment 3 2015-02-18 14:36:37 PST
Created attachment 246849 [details] Patch
Joseph Pecoraro
Comment 4 2015-02-18 15:20:46 PST
Comment on attachment 246849 [details] Patch r=me! Thanks.
Brent Fulgham
Comment 5 2015-02-18 16:20:23 PST
Committed r180324: <http://trac.webkit.org/changeset/180324>
Note You need to log in before you can comment on or make changes to this bug.