Bug 141761

Summary: Streamline unexported function build fixes
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: WebCore Misc.Assignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, ddkilzer, mrowe
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch
none
proposed patch achristensen: review+

Alexey Proskuryakov
Reported 2015-02-18 11:39:20 PST
We don't need both an unexp file, and a special case in check-for-weak-vtables-andexternals.
Attachments
proposed patch (4.14 KB, patch)
2015-02-18 11:44 PST, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
proposed patch (6.74 KB, patch)
2015-02-18 11:46 PST, Alexey Proskuryakov 		achristensen: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2015-02-18 11:44:14 PST
Created attachment 246831 [details] proposed patch
Alexey Proskuryakov
Comment 2 2015-02-18 11:46:36 PST
Created attachment 246832 [details] proposed patch Forgot to include Tools changes.
Alexey Proskuryakov
Comment 3 2015-02-18 11:48:23 PST
This is still a hack. It doesn't seem like we have any legitimate way to use the same name for a soft linked symbol, that's an ODR violation. Alex is going to switch to using a #define for that.
Alex Christensen
Comment 4 2015-02-18 11:53:45 PST
Comment on attachment 246832 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=246832&action=review > Tools/Scripts/check-for-weak-vtables-and-externals:110 > +# unlink $executablePath; Get rid of this change
Alex Christensen
Comment 5 2015-02-18 12:09:37 PST
http://trac.webkit.org/changeset/180282
Note You need to log in before you can comment on or make changes to this bug.