Bug 141761

Summary:

Streamline unexported function build fixes

Product:

WebKit

Reporter:

Alexey Proskuryakov <ap>

Component:

WebCore Misc.

Assignee:

Alexey Proskuryakov <ap>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, ddkilzer, mrowe

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
proposed patch	none
proposed patch	achristensen: review+

Description Alexey Proskuryakov 2015-02-18 11:39:20 PST

We don't need both an unexp file, and a special case in check-for-weak-vtables-andexternals.

Comment 1 Alexey Proskuryakov 2015-02-18 11:44:14 PST

Created attachment 246831 [details]
proposed patch

Comment 2 Alexey Proskuryakov 2015-02-18 11:46:36 PST

Created attachment 246832 [details]
proposed patch

Forgot to include Tools changes.

Comment 3 Alexey Proskuryakov 2015-02-18 11:48:23 PST

This is still a hack. It doesn't seem like we have any legitimate way to use the same name for a soft linked symbol, that's an ODR violation. Alex is going to switch to using a #define for that.

Comment 4 Alex Christensen 2015-02-18 11:53:45 PST

Comment on attachment 246832 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=246832&action=review

> Tools/Scripts/check-for-weak-vtables-and-externals:110
> +#    unlink $executablePath;

Get rid of this change

Comment 5 Alex Christensen 2015-02-18 12:09:37 PST

http://trac.webkit.org/changeset/180282