Bug 141754

Summary: Rename FontGlyphs to FontCascadeFonts
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, mmaxfield
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
patch
none
another
kling: review+
patch
none
another none

Antti Koivisto
Reported 2015-02-18 08:17:25 PST
The name is misleading.
Attachments
patch (73.22 KB, patch)
2015-02-18 08:24 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
patch (76.52 KB, patch)
2015-02-18 11:19 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
another (76.47 KB, patch)
2015-02-18 11:30 PST, Antti Koivisto 		kling: review+
DetailsFormatted DiffDiff
patch (76.95 KB, patch)
2015-02-18 12:09 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
another (77.16 KB, patch)
2015-02-18 12:38 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2015-02-18 08:24:49 PST
Created attachment 246816 [details] patch FontGlyphs -> FontCascadeFonts Not a great name but the best I could come up with. FontCascadeImpl would be more vague.
Antti Koivisto
Comment 2 2015-02-18 11:19:29 PST
Created attachment 246828 [details] patch
Antti Koivisto
Comment 3 2015-02-18 11:30:58 PST
Created attachment 246829 [details] another
Andreas Kling
Comment 4 2015-02-18 12:04:40 PST
Comment on attachment 246829 [details] another r=me :| 1>..\platform\graphics\win\FontWin.cpp(30): fatal error C1083: Cannot open include file: 'FontGlyphs.h': No such file or directory
Antti Koivisto
Comment 5 2015-02-18 12:09:01 PST
Created attachment 246836 [details] patch
Antti Koivisto
Comment 6 2015-02-18 12:38:41 PST
Created attachment 246841 [details] another
WebKit Commit Bot
Comment 7 2015-02-18 14:23:35 PST
Comment on attachment 246841 [details] another Clearing flags on attachment: 246841 Committed r180294: <http://trac.webkit.org/changeset/180294>
WebKit Commit Bot
Comment 8 2015-02-18 14:23:39 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.