Bug 141754

Summary: Rename FontGlyphs to FontCascadeFonts
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, mmaxfield
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
patch
none
another
kling: review+
patch
none
another none

Description Antti Koivisto 2015-02-18 08:17:25 PST 
The name is misleading.
Comment 1 Antti Koivisto 2015-02-18 08:24:49 PST 
Created attachment 246816 [details]
patch

FontGlyphs -> FontCascadeFonts

Not a great name but the best I could come up with. FontCascadeImpl would be more vague.
Comment 2 Antti Koivisto 2015-02-18 11:19:29 PST 
Created attachment 246828 [details]
patch
Comment 3 Antti Koivisto 2015-02-18 11:30:58 PST 
Created attachment 246829 [details]
another
Comment 4 Andreas Kling 2015-02-18 12:04:40 PST 
Comment on attachment 246829 [details]
another

r=me :|

     1>..\platform\graphics\win\FontWin.cpp(30): fatal error C1083: Cannot open include file: 'FontGlyphs.h': No such file or directory
Comment 5 Antti Koivisto 2015-02-18 12:09:01 PST 
Created attachment 246836 [details]
patch
Comment 6 Antti Koivisto 2015-02-18 12:38:41 PST 
Created attachment 246841 [details]
another
Comment 7 WebKit Commit Bot 2015-02-18 14:23:35 PST 
Comment on attachment 246841 [details]
another

Clearing flags on attachment: 246841

Committed r180294: <http://trac.webkit.org/changeset/180294>
Comment 8 WebKit Commit Bot 2015-02-18 14:23:39 PST 
All reviewed patches have been landed.  Closing bug.