Bug 141751

Summary:

Adopt WebCore::IOSurface in ImageBuffer

Product:

WebKit

Reporter:

Tim Horton <thorton>

Component:

New Bugs

Assignee:

Tim Horton <thorton>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, simon.fraser

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Windows build fix	none
Patch	none

Description Tim Horton 2015-02-18 04:31:00 PST

Adopt WebCore::IOSurface in ImageBuffer

Comment 1 Tim Horton 2015-02-18 04:36:40 PST

Created attachment 246811 [details]
Patch

Comment 2 Tim Horton 2015-02-18 04:38:55 PST

There are a few more cleanups that could come after this:
    * Add some kind of IOSurface::Locker and byte-ptr getter and whatnot.
    * Make it harder to get to ImageBuffer::m_surface. Move it to ImageBufferData, in the software-only section?
    * Decide whether we should keep 160121 and delete a bunch of code if not
    * Turn on pooling of ImageBuffer backing surfaces

Comment 3 Tim Horton 2015-02-18 12:06:44 PST

Created attachment 246835 [details]
Windows build fix

Comment 4 Tim Horton 2015-02-18 13:49:52 PST

Created attachment 246845 [details]
Patch

Comment 5 Tim Horton 2015-02-18 13:50:25 PST

Simon reviewed this, just trying to get through Windows EWS.

Comment 6 Tim Horton 2015-02-18 15:06:16 PST

http://trac.webkit.org/changeset/180308

Comment 7 Tim Horton 2015-02-18 16:38:20 PST

Build fix in http://trac.webkit.org/changeset/180330