Bug 141751

Summary: Adopt WebCore::IOSurface in ImageBuffer
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Windows build fix
none
Patch none

Tim Horton
Reported 2015-02-18 04:31:00 PST
Adopt WebCore::IOSurface in ImageBuffer
Attachments
Patch (27.48 KB, patch)
2015-02-18 04:36 PST, Tim Horton 		no flags
DetailsFormatted DiffDiff
Windows build fix (27.49 KB, patch)
2015-02-18 12:06 PST, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (27.54 KB, patch)
2015-02-18 13:49 PST, Tim Horton 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2015-02-18 04:36:40 PST
Created attachment 246811 [details] Patch
Tim Horton
Comment 2 2015-02-18 04:38:55 PST
There are a few more cleanups that could come after this: * Add some kind of IOSurface::Locker and byte-ptr getter and whatnot. * Make it harder to get to ImageBuffer::m_surface. Move it to ImageBufferData, in the software-only section? * Decide whether we should keep 160121 and delete a bunch of code if not * Turn on pooling of ImageBuffer backing surfaces
Tim Horton
Comment 3 2015-02-18 12:06:44 PST
Created attachment 246835 [details] Windows build fix
Tim Horton
Comment 4 2015-02-18 13:49:52 PST
Created attachment 246845 [details] Patch
Tim Horton
Comment 5 2015-02-18 13:50:25 PST
Simon reviewed this, just trying to get through Windows EWS.
Tim Horton
Comment 6 2015-02-18 15:06:16 PST
http://trac.webkit.org/changeset/180308
Tim Horton
Comment 7 2015-02-18 16:38:20 PST
Build fix in http://trac.webkit.org/changeset/180330
Note You need to log in before you can comment on or make changes to this bug.