Bug 141746
| Summary: | REGRESSION(r180235): It broke the !ENABLE(PROMISES) build | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Csaba Osztrogonác <ossy> |
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | joepeck, timothy |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 141634 | ||
Csaba Osztrogonác
build log:
../../Source/JavaScriptCore/inspector/JSInjectedScriptHost.cpp: In member function 'JSC::JSValue Inspector::JSInjectedScriptHost::getInternalProperties(JSC::ExecState*)':
../../Source/JavaScriptCore/inspector/JSInjectedScriptHost.cpp:212:9: error: 'JSPromise' was not declared in this scope
The problem is that JSPromise type is used unconditionally,
but it is defined inside ENABLE(PROMISES) guard.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Joseph Pecoraro
Oops, somehow I didn't even notice that this was behind an enable flag. I'll fix. Thanks for alerting me.
Joseph Pecoraro
Should be fixed by:
http://trac.webkit.org/changeset/180259