Summary: | [iOS] Fix inefficiencies in ResourceResponse::platformLazyInit() | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||
Component: | Page Loading | Assignee: | Chris Dumez <cdumez> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | ap, commit-queue, darin, ggaren, kling, koivisto, mitz | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | iPhone / iPad | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Chris Dumez
2015-02-17 21:26:48 PST
Created attachment 246801 [details]
Patch
ping review? Comment on attachment 246801 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=246801&action=review > Source/WebCore/platform/network/cf/ResourceResponseCFNet.cpp:107 > - if (m_initLevel < AllFields) { > + if (m_initLevel < AllFields && initLevel == AllFields) { Whoa. Did this regress recently? @Alexey: I know you have strong feelings about making changes to the iOS resource loader code at this point in time. Care to comment on this change? (In reply to comment #4) > @Alexey: I know you have strong feelings about making changes to the iOS > resource loader code at this point in time. Care to comment on this change? Oh oops, this comment landed just after you commented! Thanks :-) Comment on attachment 246801 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=246801&action=review >> Source/WebCore/platform/network/cf/ResourceResponseCFNet.cpp:107 >> + if (m_initLevel < AllFields && initLevel == AllFields) { > > Whoa. Did this regress recently? Yes, I think this regressed in <https://trac.webkit.org/r173272>. Comment on attachment 246801 [details] Patch Clearing flags on attachment: 246801 Committed r180353: <http://trac.webkit.org/changeset/180353> All reviewed patches have been landed. Closing bug. |