Bug 141735

Summary:

Prepare to use WEBCORE_EXPORT on Windows

Product:

WebKit

Reporter:

Alex Christensen <achristensen>

Component:

WebKit Misc.

Assignee:

Alex Christensen <achristensen>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, burg, commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

141734

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none

Alex Christensen

Reported 2015-02-17 18:49:38 PST

Windows needs a few changes to use WEBCORE_EXPORT.

Attachments
Patch (30.12 KB, patch) 2015-02-17 19:02 PST, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (75.80 KB, patch) 2015-02-17 19:45 PST, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (73.92 KB, patch) 2015-02-17 21:33 PST, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (73.42 KB, patch) 2015-02-17 21:37 PST, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (72.72 KB, patch) 2015-02-18 13:37 PST, Alex Christensen	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Alex Christensen

Comment 1 2015-02-17 19:00:45 PST

Note: check the bindings tests before landing.

Alex Christensen

Comment 2 2015-02-17 19:02:37 PST

Created attachment 246784 [details] Patch

Alex Christensen

Comment 3 2015-02-17 19:45:02 PST

Created attachment 246792 [details] Patch

Alex Christensen

Comment 4 2015-02-17 21:33:48 PST

Created attachment 246799 [details] Patch

Alex Christensen

Comment 5 2015-02-17 21:37:49 PST

Created attachment 246800 [details] Patch

Brent Fulgham

Comment 6 2015-02-17 22:50:45 PST

Comment on attachment 246800 [details] Patch This patch seems fine, but may tend to expose more symbols than strictly necessary since we are now marking the entire class for export, rather than just specific functions. The maintenance benefit from this approach probably far outweighs any negatives, though.

WebKit Commit Bot

Comment 7 2015-02-18 13:33:07 PST

Comment on attachment 246800 [details] Patch Rejecting attachment 246800 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 246800, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: WebCore/platform/network/BlobDataFileReference.h patching file Source/WebCore/platform/network/BlobRegistry.h patching file Source/WebCore/platform/network/BlobRegistryImpl.h patching file Source/WebCore/platform/sql/SQLiteDatabase.h patching file Source/WebCore/rendering/ScrollBehavior.h patching file Source/WebCore/rendering/break_lines.h Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Brent Fulgham']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/4612572569403392

Alex Christensen

Comment 8 2015-02-18 13:37:31 PST

Created attachment 246842 [details] Patch

Brent Fulgham

Comment 9 2015-02-18 13:41:24 PST

Comment on attachment 246842 [details] Patch r=me

WebKit Commit Bot

Comment 10 2015-02-18 14:39:15 PST

Comment on attachment 246842 [details] Patch Clearing flags on attachment: 246842 Committed r180301: <http://trac.webkit.org/changeset/180301>

WebKit Commit Bot

Comment 11 2015-02-18 14:39:19 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.