Bug 141715

Summary: Cleanup: Use @memoized for property IOSSimulator.testing_device
Product: WebKit Reporter: Daniel Bates <dbates>
Component: Tools / TestsAssignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, ddkilzer, glenn, jake.nielsen.webkit
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: iPhone / iPad   
OS: iOS 8.1   
Bug Depends on: 141711    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Daniel Bates
Reported 2015-02-17 10:18:03 PST
We can simplify the logic in IOSSimulatorPort for caching the testing device by using the @memoized decorator.
Attachments
Patch (4.61 KB, patch)
2015-02-17 10:22 PST, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Patch (3.88 KB, patch)
2015-04-23 15:52 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2015-02-17 10:22:09 PST
Created attachment 246753 [details] Patch
Daniel Bates
Comment 2 2015-04-23 15:52:41 PDT
Created attachment 251504 [details] Patch
Jake Nielsen
Comment 3 2015-04-23 16:37:47 PDT
Nice!
Daniel Bates
Comment 4 2015-04-24 14:40:13 PDT
Comment on attachment 251504 [details] Patch Clearing flags on attachment: 251504 Committed r183281: <http://trac.webkit.org/changeset/183281>
Daniel Bates
Comment 5 2015-04-24 14:40:19 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.