Bug 141711

Summary:

run_webkit_tests.py should not know about iOS Simulator details

Product:

WebKit

Reporter:

Daniel Bates <dbates>

Component:

Tools / Tests

Assignee:

Daniel Bates <dbates>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, commit-queue, ddkilzer, glenn, jake.nielsen.webkit

Priority:

Version:

528+ (Nightly build)

Hardware:

iPhone / iPad

OS:

iOS 8.1

Bug Depends on:

Bug Blocks:

141715, 141718

Attachments:

Description	Flags
Patch	none

Description Daniel Bates 2015-02-17 09:50:38 PST

run_webkit_tests.py should only parse the iOS Simulator command line options --runtime and --device-type. The IOSSimulatorPort object should be responsible for validating these parsed values and instantiating internal data structures to represent them.

Comment 1 Daniel Bates 2015-02-17 09:56:37 PST

Created attachment 246750 [details]
Patch

Comment 2 Daniel Bates 2015-02-17 14:13:19 PST

Comment on attachment 246750 [details]
Patch

Clearing flags on attachment: 246750

Committed r180238: <http://trac.webkit.org/changeset/180238>

Comment 3 Daniel Bates 2015-02-17 14:13:23 PST

All reviewed patches have been landed.  Closing bug.