Bug 141711

Summary: run_webkit_tests.py should not know about iOS Simulator details
Product: WebKit Reporter: Daniel Bates <dbates>
Component: Tools / TestsAssignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, ddkilzer, glenn, jake.nielsen.webkit
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: iPhone / iPad   
OS: iOS 8.1   
Bug Depends on:    
Bug Blocks: 141715, 141718    
Attachments:
Description Flags
Patch none

Daniel Bates
Reported 2015-02-17 09:50:38 PST
run_webkit_tests.py should only parse the iOS Simulator command line options --runtime and --device-type. The IOSSimulatorPort object should be responsible for validating these parsed values and instantiating internal data structures to represent them.
Attachments
Patch (9.54 KB, patch)
2015-02-17 09:56 PST, Daniel Bates 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2015-02-17 09:56:37 PST
Created attachment 246750 [details] Patch
Daniel Bates
Comment 2 2015-02-17 14:13:19 PST
Comment on attachment 246750 [details] Patch Clearing flags on attachment: 246750 Committed r180238: <http://trac.webkit.org/changeset/180238>
Daniel Bates
Comment 3 2015-02-17 14:13:23 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.