Bug 141709

Summary: [GTK] Layout Tests for cross-frame http are failing since expectation changed
Product: WebKit Reporter: Marcos Chavarría Teijeiro (irc: chavaone) <chavarria1991>
Component: Tools / TestsAssignee: Carlos Alberto Lopez Perez <clopez>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, bugs-noreply, chavarria1991, clopez, commit-queue, cturner, mmaxfield
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Marcos Chavarría Teijeiro (irc: chavaone)
Reported 2015-02-17 09:46:47 PST
The http/tests/security/cross-frame-access-callback-explicit-domain-ALLOW.html and http/tests/security/XFrameOptions/x-frame-options-deny-multiple-clients-expected.txt layout tests are failing since *-expected file spacing was changed on r180202 (https://trac.webkit.org/changeset/180202). The diff is the following: https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20%28Tests%29/r180216%20%286297%29/http/tests/security/cross-frame-access-callback-explicit-domain-ALLOW-pretty-diff.html https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20%28Tests%29/r180216%20%286297%29/http/tests/security/XFrameOptions/x-frame-options-deny-multiple-clients-pretty-diff.html
Attachments
Patch (5.02 KB, patch)
2015-05-05 02:40 PDT, Marcos Chavarría Teijeiro (irc: chavaone) 		no flags
DetailsFormatted DiffDiff
Patch (6.00 KB, patch)
2017-06-08 08:19 PDT, Carlos Alberto Lopez Perez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Marcos Chavarría Teijeiro (irc: chavaone)
Comment 1 2015-05-05 02:40:05 PDT
Created attachment 252372 [details] Patch
Carlos Alberto Lopez Perez
Comment 2 2017-06-08 06:21:07 PDT
I missed this somehow. Let's see if this passes Mac/iOS EWS and land it.
Carlos Alberto Lopez Perez
Comment 3 2017-06-08 08:19:13 PDT
Created attachment 312305 [details] Patch Patch for landing
WebKit Commit Bot
Comment 4 2017-06-08 10:01:54 PDT
Comment on attachment 312305 [details] Patch Clearing flags on attachment: 312305 Committed r217931: <http://trac.webkit.org/changeset/217931>
WebKit Commit Bot
Comment 5 2017-06-08 10:01:56 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.