Bug 141706

Summary:

[GTK] Layout Test fast/forms/color/input-appearance-color.html is failing

Product:

WebKit

Reporter:

Marcos Chavarría Teijeiro (irc: chavaone) <chavarria1991>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cgarcia, chavarria1991, gustavo

Priority:

P2

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none

Marcos Chavarría Teijeiro (irc: chavaone)

Reported 2015-02-17 08:30:01 PST

The fast/forms/color/input-appearance-color.html layout test is failing since it was added in r179922 (http://trac.webkit.org/r179922) The diff is the following: https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20%28Tests%29/r180216%20%286297%29/fast/forms/color/input-appearance-color-pretty-diff.html

Attachments
Patch (8.75 KB, patch) 2015-03-11 06:15 PDT, Marcos Chavarría Teijeiro (irc: chavaone)	no flags	Details Formatted Diff Diff
Patch (8.75 KB, patch) 2015-03-12 01:30 PDT, Marcos Chavarría Teijeiro (irc: chavaone)	no flags	Details Formatted Diff Diff
Patch (30.24 KB, patch) 2015-03-12 02:16 PDT, Marcos Chavarría Teijeiro (irc: chavaone)	no flags	Details Formatted Diff Diff
Patch (30.17 KB, patch) 2015-04-15 00:50 PDT, Marcos Chavarría Teijeiro (irc: chavaone)	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Marcos Chavarría Teijeiro (irc: chavaone)

Comment 1 2015-03-11 06:15:31 PDT

Created attachment 248416 [details] Patch

Carlos Garcia Campos

Comment 2 2015-03-11 06:20:06 PDT

Comment on attachment 248416 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=248416&action=review > LayoutTests/ChangeLog:12 > + causing the whole page to return wrong values.We probably could make a values.We -> values. We

Marcos Chavarría Teijeiro (irc: chavaone)

Comment 3 2015-03-12 01:30:03 PDT

Created attachment 248500 [details] Patch

Sergio Villar Senin

Comment 4 2015-03-12 01:42:44 PDT

Comment on attachment 248500 [details] Patch Mac port has a pixel test for this (there is a png expected result). We should likely do the same as it's quite complicated to know what we're testing without a picture.

Marcos Chavarría Teijeiro (irc: chavaone)

Comment 5 2015-03-12 02:16:40 PDT

Created attachment 248502 [details] Patch

Marcos Chavarría Teijeiro (irc: chavaone)

Comment 6 2015-04-15 00:50:05 PDT

Created attachment 250779 [details] Patch

Marcos Chavarría Teijeiro (irc: chavaone)

Comment 7 2015-05-06 00:29:32 PDT

This test were finally rebaselined at revision r183802 (http://trac.webkit.org/changeset/183802).

Note You need to log in before you can comment on or make changes to this bug.