Bug 141683 – HTMLFormControlElement::didAttachRenderers() should not force layout via focus() until the style resolution is done

• Component: Forms
• Status: RESOLVED DUPLICATE

[Simon Fraser (smfr)]

HTMLFormControlElement::didAttachRenderers() has:

        Style::queuePostResolutionCallback([element] {
            element->focus();
        });

The focus call forces layout, but too soon, before we've done with the rest of Document::recalcStyle()

1   com.apple.WebCore             	0x000000010fc5a636 WebCore::FrameView::layout(bool) + 246 (FrameView.cpp:1126)
2   com.apple.WebCore             	0x000000010f8c8357 WebCore::Document::updateLayout() + 343 (Document.cpp:1857)
3   com.apple.WebCore             	0x000000010f8cbdaf WebCore::Document::updateLayoutIgnorePendingStylesheets(WebCore::Document::RunPostLayoutTasks) + 207 (Document.cpp:1891)
4   com.apple.WebCore             	0x000000010fa70084 WebCore::Element::focus(bool, WebCore::FocusDirection) + 148 (Element.cpp:1983)
5   com.apple.WebCore             	0x000000010fdd6508 WebCore::HTMLFormControlElement::didAttachRenderers()::$_0::operator()() const + 40 (HTMLFormControlElement.cpp:225)
6   com.apple.WebCore             	0x000000010fdd64cc std::__1::__function::__func<WebCore::HTMLFormControlElement::didAttachRenderers()::$_0, std::__1::allocator<WebCore::HTMLFormControlElement::didAttachRenderers()::$_0>, void ()>::operator()() + 60 (functional:1370)
7   com.apple.WebCore             	0x000000010f3cc3aa std::__1::function<void ()>::operator()() const + 26 (functional:1756)
8   com.apple.WebCore             	0x000000011107ca10 WebCore::Style::PostResolutionCallbackDisabler::~PostResolutionCallbackDisabler() + 96 (StyleResolveTree.cpp:1046)
9   com.apple.WebCore             	0x000000011107ca95 WebCore::Style::PostResolutionCallbackDisabler::~PostResolutionCallbackDisabler() + 21 (StyleResolveTree.cpp:1054)
10  com.apple.WebCore             	0x000000010f8cb51c WebCore::Document::recalcStyle(WebCore::Style::Change) + 764 (Document.cpp:1795)
11  com.apple.WebCore             	0x000000010f8c745b WebCore::Document::updateStyleIfNeeded() + 347 (Document.cpp:1833)
12  com.apple.WebCore             	0x000000010f8cba76 WebCore::Document::implicitClose() + 1094 (Document.cpp:2516)
13  com.apple.WebCore             	0x000000010fc24e1b WebCore::FrameLoader::checkCallImplicitClose() + 155 (FrameLoader.cpp:901)
14  com.apple.WebCore             	0x000000010fc24aee WebCore::FrameLoader::checkCompleted() + 270 (FrameLoader.cpp:848)
15  com.apple.WebCore             	0x000000010fc235f2 WebCore::FrameLoader::finishedParsing() + 178 (FrameLoader.cpp:768)
16  com.apple.WebCore             	0x000000010f8d8133 WebCore::Document::finishedParsing() + 483 (Document.cpp:4649)
17  com.apple.WebCore             	0x000000010fd73288 WebCore::HTMLConstructionSite::finishedParsing() + 24 (HTMLConstructionSite.cpp:405)
18  com.apple.WebCore             	0x000000010feaaada WebCore::HTMLTreeBuilder::finished() + 186 (HTMLTreeBuilder.cpp:2942)
19  com.apple.WebCore             	0x000000010fda15ae WebCore::HTMLDocumentParser::end() + 190 (HTMLDocumentParser.cpp:403)
20  com.apple.WebCore             	0x000000010fd9f9fe WebCore::HTMLDocumentParser::attemptToRunDeferredScriptsAndEnd() + 254 (HTMLDocumentParser.cpp:412)
21  com.apple.WebCore             	0x000000010fd9f79e WebCore::HTMLDocumentParser::prepareToStopParsing() + 270 (HTMLDocumentParser.cpp:133)
22  com.apple.WebCore             	0x000000010fda15ff WebCore::HTMLDocumentParser::attemptToEnd() + 63 (HTMLDocumentParser.cpp:424)
23  com.apple.WebCore             	0x000000010fda1658 WebCore::HTMLDocumentParser::finish() + 72 (HTMLDocumentParser.cpp:452)
24  com.apple.WebCore             	0x000000010f95bfac WebCore::DocumentWriter::end() + 332 (DocumentWriter.cpp:247)
25  com.apple.WebCore             	0x000000010f923e46 WebCore::DocumentLoader::finishedLoading(double) + 1574 (DocumentLoader.cpp:442)
26  com.apple.WebCore             	0x000000010f92378e WebCore::DocumentLoader::notifyFinished(WebCore::CachedResource*) + 270 (DocumentLoader.cpp:376)
27  com.apple.WebCore             	0x000000010f57bd92 WebCore::CachedResource::checkNotify() + 130 (CachedResource.cpp:292)
28  com.apple.WebCore             	0x000000010f57bea1 WebCore::CachedResource::finishLoading(WebCore::SharedBuffer*) + 49 (CachedResource.cpp:310)
29  com.apple.WebCore             	0x000000010f5778ca WebCore::CachedRawResource::finishLoading(WebCore::SharedBuffer*) + 218 (CachedRawResource.cpp:105)
30  com.apple.WebCore             	0x000000011109dbd5 WebCore::SubresourceLoader::didFinishLoading(double) + 517 (SubresourceLoader.cpp:366)
31  com.apple.WebCore             	0x0000000110d8e415 WebCore::ResourceLoader::didFinishLoading(WebCore::ResourceHandle*, double) + 53 (ResourceLoader.cpp:543)
32  com.apple.WebCore             	0x000000011133efaa -[WebCoreResourceHandleAsDelegate connectionDidFinishLoading:] + 186 (WebCoreResourceHandleAsDelegate.mm:261)
33  com.apple.CFNetwork           	0x00007fff9055620d __65-[NSURLConnectionInternal _withConnectionAndDelegate:onlyActive:]_block_invoke + 69

[Simon Fraser (smfr)]

Zalan, you fixed this.

[alan]

yay

[alan]

*** This bug has been marked as a duplicate of bug 155503 ***