Bug 141679

Summary: Update cross-frame http tests after r177774
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, dino, jonlee, simon.fraser, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 139968    
Attachments:
Description Flags
Patch ap: review+, commit-queue: commit-queue-

Myles C. Maxfield
Reported 2015-02-16 16:40:49 PST
Update cross-frame http tests after r177774
Attachments
Patch (3.92 KB, patch)
2015-02-16 16:41 PST, Myles C. Maxfield
ap: review+
commit-queue: commit-queue-
Myles C. Maxfield
Comment 1 2015-02-16 16:41:44 PST
Alexey Proskuryakov
Comment 2 2015-02-16 17:28:42 PST
Comment on attachment 246702 [details] Patch I don't see how r177774 could possibly affect this. It may be worth digging deeper. That said, flakiness with spaces that correspond to iframe and object elements is somewhat common on tests, I think that it's a bug in line layout code, where it produces different results depending on whether layout happens before or after a newline after the element is parsed. As such, this is probably OK to land.
Myles C. Maxfield
Comment 3 2015-02-16 17:31:11 PST
WebKit Commit Bot
Comment 4 2015-02-16 18:15:06 PST
Comment on attachment 246702 [details] Patch Rejecting attachment 246702 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 246702, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: -> origin/master Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 180195 = 25e4353fede138ac39388c7aeaea2fd0986a38e3 r180197 = ade3d778dcc2af6eca1825eb7d846e2feeb6f8e7 r180200 = a9bfab5ed24fe57aa74ab2510808f9a553d95f14 Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: http://webkit-queues.appspot.com/results/4752338422071296
Myles C. Maxfield
Comment 5 2015-02-16 18:21:19 PST
Note You need to log in before you can comment on or make changes to this bug.