Bug 141672

Summary:

ASan does not like JSC::MachineThreads::tryCopyOtherThreadStack

Product:

WebKit

Reporter:

Dana Burkart <dburkart>

Component:

Tools / Tests

Assignee:

Mark Lam <mark.lam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, commit-queue, dburkart, ddkilzer, ggaren, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Ignore JSC::MachineThreads::tryCopyOtherThreadStack	none
Patch with updated fix	none

Description Dana Burkart 2015-02-16 15:42:26 PST

From Geoff:

Since JSC::MachineThreads::tryCopyOtherThreadStack reads another thread's stack.

We should use one of the ASan annotations to make ASan ignore this function or treat it in a more lax way.

Comment 1 Dana Burkart 2015-02-16 15:42:39 PST

<rdar://problem/19828843>

Comment 2 Radar WebKit Bug Importer 2015-02-16 15:43:09 PST

<rdar://problem/19853304>

Comment 3 Dana Burkart 2015-02-16 15:46:34 PST

<rdar://problem/19828843>

Comment 4 Dana Burkart 2015-02-16 16:59:09 PST

Created attachment 246705 [details]
Ignore JSC::MachineThreads::tryCopyOtherThreadStack

Comment 5 David Kilzer (:ddkilzer) 2015-02-17 09:23:03 PST

Comment on attachment 246705 [details]
Ignore JSC::MachineThreads::tryCopyOtherThreadStack

r=me

Comment 6 WebKit Commit Bot 2015-02-17 10:06:36 PST

Comment on attachment 246705 [details]
Ignore JSC::MachineThreads::tryCopyOtherThreadStack

Clearing flags on attachment: 246705

Committed r180227: <http://trac.webkit.org/changeset/180227>

Comment 7 WebKit Commit Bot 2015-02-17 10:06:40 PST

All reviewed patches have been landed.  Closing bug.

Comment 8 Alexey Proskuryakov 2015-02-18 12:40:20 PST

This fixes run-webkit-tests --threaded

Comment 9 Alexey Proskuryakov 2015-02-24 22:01:47 PST

Geoff, did this actually fix the issue? Looking at bug 141990 comment 10, ASan can still crash under this function, because the violation happens in memcpy, not in this function.

Comment 10 Alexey Proskuryakov 2015-02-25 16:27:01 PST

Mark Lam replaced this fix with a different one in <https://trac.webkit.org/r180649>. We now hit this code path on worker tests too, and this fix was ineffective.

Comment 11 Mark Lam 2015-02-25 16:28:50 PST

Created attachment 247361 [details]
Patch with updated fix

This patch was reviewed and r+'ed offline by Alexey.

Comment 12 Mark Lam 2015-02-25 16:30:28 PST

The fix is landed in r180649: <http://trac.webkit.org/r180649>.