Bug 141632

Summary: Rare case profiling should actually work
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
the patch msaboff: review+

Filip Pizlo
Reported 2015-02-15 21:18:46 PST
Currently, the "likelyToTakeSlowCaseMinimumCount" threshold is 100, which is larger than the number of times a typical bytecode instruction will execute before being DFG compiled (that threshold averages around 1000/15 ~ 66). This means that the rare case profiling doesn't actually help us avoid overspeculating.
Attachments
the patch (1.83 KB, patch)
2015-02-15 22:13 PST, Filip Pizlo 		msaboff: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2015-02-15 22:13:35 PST
Created attachment 246634 [details] the patch
Michael Saboff
Comment 2 2015-02-15 22:15:22 PST
Comment on attachment 246634 [details] the patch r=me
Filip Pizlo
Comment 3 2015-02-15 22:19:45 PST
Landed in http://trac.webkit.org/changeset/180137
Note You need to log in before you can comment on or make changes to this bug.