Bug 141632

Summary: Rare case profiling should actually work
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
the patch msaboff: review+

Description Filip Pizlo 2015-02-15 21:18:46 PST 
Currently, the "likelyToTakeSlowCaseMinimumCount" threshold is 100, which is larger than the number of times a typical bytecode instruction will execute before being DFG compiled (that threshold averages around 1000/15 ~ 66).  This means that the rare case profiling doesn't actually help us avoid overspeculating.
Comment 1 Filip Pizlo 2015-02-15 22:13:35 PST 
Created attachment 246634 [details]
the patch
Comment 2 Michael Saboff 2015-02-15 22:15:22 PST 
Comment on attachment 246634 [details]
the patch

r=me
Comment 3 Filip Pizlo 2015-02-15 22:19:45 PST 
Landed in http://trac.webkit.org/changeset/180137