Summary: | DFG::PutStackSinkingPhase should eliminate GetStacks that have an obviously known source, and emit GetStacks when the stack's value is needed and none is deferred | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> | ||||||
Component: | JavaScriptCore | Assignee: | Filip Pizlo <fpizlo> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | barraclough, benjamin, commit-queue, ggaren, mark.lam, mhahnenb, mmirman, msaboff, nrotem, oliver, saam, sam, simon.fraser | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Bug Depends on: | 142695, 142697 | ||||||||
Bug Blocks: | 141174 | ||||||||
Attachments: |
|
Description
Filip Pizlo
2015-02-15 14:41:02 PST
Created attachment 248599 [details]
the patch
Landed in http://trac.webkit.org/changeset/181487 This is causing a jsc test failure: https://build.webkit.org/builders/Apple%20Mavericks%20Release%20WK2%20%28Perf%29 Running Speedometer/Full.html (144 of 144) error: Speedometer/Full.html 1 0x108f858a3 JSC::DFG::(anonymous namespace)::PutStackSinkingPhase::run() 2 0x108f7c5f4 JSC::DFG::performPutStackSinking(JSC::DFG::Graph&) 3 0x108fd5cf9 JSC::DFG::Plan::compileInThreadImpl(JSC::DFG::LongLivedState&) 4 0x108fd5601 JSC::DFG::Plan::compileInThread(JSC::DFG::LongLivedState&, JSC::DFG::ThreadData*) 5 0x1090601d3 JSC::DFG::Worklist::runThread(JSC::DFG::ThreadData*) 6 0x1093c5bd3 WTF::threadEntryPoint(void*) 7 0x1093c608f WTF::wtfThreadEntryPoint(void*) 8 0x7fff85ad7899 _pthread_body 9 0x7fff85ad772a _pthread_struct_init 10 0x7fff85adbfc9 thread_start Re-opened since this is blocked by bug 142695 Comment on attachment 248599 [details]
the patch
This patch was broken, and it revealed some other issues in this phase. I'll have a new patch shortly.
Created attachment 248700 [details]
the patch
Comment on attachment 248700 [details]
the patch
r=me
Landed in http://trac.webkit.org/changeset/181563 |