Bug 141622

Summary:

Web Inspector: remove unused XHR replay code

Product:

WebKit

Reporter:

Brian Burg <burg>

Component:

Web Inspector

Assignee:

Brian Burg <burg>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, graouts, japhet, joepeck, jonowells, mattbaker, nvasilyev, sabouhallawa, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Proposed Fix	none

Brian Burg

Reported 2015-02-15 11:24:17 PST

It hasn't been used since the new frontend.

Attachments
Proposed Fix (32.75 KB, patch) 2015-02-15 15:28 PST, Brian Burg	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2015-02-15 11:24:32 PST

<rdar://problem/19840911>

Brian Burg

Comment 2 2015-02-15 15:28:17 PST

Created attachment 246625 [details] Proposed Fix

Timothy Hatcher

Comment 3 2015-02-15 17:10:22 PST

Comment on attachment 246625 [details] Proposed Fix Nikita and I have been considering adding it to the UI. But I wouldn't want to limit it to XHR.

Brian Burg

Comment 4 2015-02-15 17:31:51 PST

(In reply to comment #3) > Comment on attachment 246625 [details] > Proposed Fix > > Nikita and I have been considering adding it to the UI. But I wouldn't want > to limit it to XHR. It's highly likely you want to revisit the design of NetworkResourcesData, it is very crufty and written in the era before NetworkProcess etc. It should be much easier to get and manage loader data now.

WebKit Commit Bot

Comment 5 2015-02-15 18:17:48 PST

Comment on attachment 246625 [details] Proposed Fix Clearing flags on attachment: 246625 Committed r180132: <http://trac.webkit.org/changeset/180132>

WebKit Commit Bot

Comment 6 2015-02-15 18:17:53 PST

All reviewed patches have been landed. Closing bug.

Said Abou-Hallawa

Comment 7 2015-02-15 18:21:49 PST

Committed r180133: <http://trac.webkit.org/changeset/180133>

Brian Burg

Comment 8 2015-02-15 18:42:47 PST

(In reply to comment #7) > Committed r180133: <http://trac.webkit.org/changeset/180133> Said, I'm not sure what you intended to do, but you reused this commit's message for something to do with SVG code. Please figure out what's going on, this is the second time I've seen your commits do this.

Note You need to log in before you can comment on or make changes to this bug.