| Summary: | Web Inspector: remove unused XHR replay code | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Brian Burg <burg> | ||||
| Component: | Web Inspector | Assignee: | Brian Burg <burg> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, graouts, japhet, joepeck, jonowells, mattbaker, nvasilyev, sabouhallawa, timothy, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
|
Description
Brian Burg
2015-02-15 11:24:17 PST
Created attachment 246625 [details]
Proposed Fix
Comment on attachment 246625 [details]
Proposed Fix
Nikita and I have been considering adding it to the UI. But I wouldn't want to limit it to XHR.
(In reply to comment #3) > Comment on attachment 246625 [details] > Proposed Fix > > Nikita and I have been considering adding it to the UI. But I wouldn't want > to limit it to XHR. It's highly likely you want to revisit the design of NetworkResourcesData, it is very crufty and written in the era before NetworkProcess etc. It should be much easier to get and manage loader data now. Comment on attachment 246625 [details] Proposed Fix Clearing flags on attachment: 246625 Committed r180132: <http://trac.webkit.org/changeset/180132> All reviewed patches have been landed. Closing bug. Committed r180133: <http://trac.webkit.org/changeset/180133> (In reply to comment #7) > Committed r180133: <http://trac.webkit.org/changeset/180133> Said, I'm not sure what you intended to do, but you reused this commit's message for something to do with SVG code. Please figure out what's going on, this is the second time I've seen your commits do this. |