Bug 141620

Summary:

Web Inspector: move WebCore agents to Inspector namespace

Product:

WebKit

Reporter:

Brian Burg <burg>

Component:

Web Inspector

Assignee:

Nobody <webkit-unassigned>

Status:

NEW ---

Severity:

Normal

CC:

graouts, inspector-bugzilla-changes, jonowells, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

141608

Bug Blocks:

Attachments:

Description	Flags
Proposed Fix	none
Proposed Fix (rebased)	none

Description Brian Burg 2015-02-15 08:27:50 PST

Comment 1 Radar WebKit Bug Importer 2015-02-15 08:28:05 PST

<rdar://problem/19840602>

Comment 2 Brian Burg 2015-02-15 19:11:10 PST

Created attachment 246631 [details]
Proposed Fix

Comment 3 Joseph Pecoraro 2015-02-27 11:06:29 PST

Comment on attachment 246631 [details]
Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=246631&action=review

Looks good. r=me

> Source/WebCore/WebCore.exp.in:1642
> +__ZN9Inspector9PageAgent7frameIdEPNS_5FrameE

I don't think this file exists anymore =).

> Source/WebCore/inspector/InspectorCSSAgent.h:101
> +    void didCreateNamedFlow(WebCore::Document&, WebCore::WebKitNamedFlow&);
> +    void willRemoveNamedFlow(WebCore::Document&, WebCore::WebKitNamedFlow&);

Arg, this is why I was afraid of moving the agents to Inspector namespace. Hopefully there aren't too many WebCore::s.

Comment 4 Brian Burg 2015-02-27 12:52:03 PST

Created attachment 247538 [details]
Proposed Fix (rebased)

Comment 5 Brian Burg 2015-02-28 09:46:18 PST

Comment on attachment 246631 [details]
Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=246631&action=review

>> Source/WebCore/WebCore.exp.in:1642
>> +__ZN9Inspector9PageAgent7frameIdEPNS_5FrameE
> 
> I don't think this file exists anymore =).

Yup, rebased patch has removed this chunk.

>> Source/WebCore/inspector/InspectorCSSAgent.h:101
>> +    void willRemoveNamedFlow(WebCore::Document&, WebCore::WebKitNamedFlow&);
> 
> Arg, this is why I was afraid of moving the agents to Inspector namespace. Hopefully there aren't too many WebCore::s.

I only found the number of prefixes to be onerous in CSSAgent and DOMAgent due to the huge number of hooks. It's only for headers though, so I think it's worth it.