Bug 141613

Summary: [Mac] Possible DDActionContext leaks, RetainPtr cleanup
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: WebKit Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
[PATCH] Proposed Fix
none
[PATCH] Proposed Fix none

Description Joseph Pecoraro 2015-02-14 18:54:37 PST 
* SUMMARY
Possible DDActionContext leaks based on shadey RetainPtr usage. Expected an adopt and there was none.

  -    RetainPtr<DDActionContext> actionContext = [allocDDActionContextInstance() init];
  +    RetainPtr<DDActionContext> actionContext = adoptNS([allocDDActionContextInstance() init]);
Comment 1 Joseph Pecoraro 2015-02-14 18:56:20 PST 
Created attachment 246607 [details]
[PATCH] Proposed Fix
Comment 2 Joseph Pecoraro 2015-02-14 19:27:49 PST 
Created attachment 246610 [details]
[PATCH] Proposed Fix
Comment 3 Tim Horton 2015-02-14 20:48:56 PST 
Comment on attachment 246610 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=246610&action=review

> Source/WebKit/mac/WebView/WebActionMenuController.mm:280
> +    RetainPtr<DDActionContext> actionContext = adoptNS([allocDDActionContextInstance() init]);

Nothing shady about it, it's just wrong. Good catch!
Comment 4 WebKit Commit Bot 2015-02-14 20:54:35 PST 
Comment on attachment 246610 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 246610

Committed r180119: <http://trac.webkit.org/changeset/180119>
Comment 5 WebKit Commit Bot 2015-02-14 20:54:39 PST 
All reviewed patches have been landed.  Closing bug.