Bug 141608

Summary: Web Inspector: remove Inspector prefixes from inspector agent classes
Product: WebKit Reporter: Brian Burg <burg>
Component: Web InspectorAssignee: Nobody <webkit-unassigned>
Status: NEW    
Severity: Normal CC: commit-queue, graouts, inspector-bugzilla-changes, joepeck, jonowells, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 141372    
Bug Blocks: 141620    
Attachments:
Description Flags
Proposed Fix
none
Proposed Fix
none
Proposed Fix (rebased) none

Brian Burg
Reported 2015-02-14 11:02:02 PST
.
Attachments
Proposed Fix (409.16 KB, patch)
2015-02-14 12:10 PST, Brian Burg 		no flags
DetailsFormatted DiffDiff
Proposed Fix (410.78 KB, patch)
2015-02-14 19:27 PST, Brian Burg 		no flags
DetailsFormatted DiffDiff
Proposed Fix (rebased) (407.25 KB, patch)
2015-02-27 10:49 PST, Brian Burg 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-02-14 11:02:34 PST
<rdar://problem/19838400>
Brian Burg
Comment 2 2015-02-14 12:10:28 PST
Created attachment 246604 [details] Proposed Fix
Brian Burg
Comment 3 2015-02-14 19:27:04 PST
Created attachment 246609 [details] Proposed Fix
WebKit Commit Bot
Comment 4 2015-02-14 19:29:54 PST
This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)
Timothy Hatcher
Comment 5 2015-02-14 19:39:21 PST
Comment on attachment 246609 [details] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=246609&action=review > Source/WebCore/inspector/CommandLineAPIHost.h:67 > + , Inspector::ConsoleAgent* consoleAgent Drop the namespace here. > Source/WebCore/inspector/CommandLineAPIHost.h:105 > + Inspector::ConsoleAgent* m_consoleAgent; Ditto.
Brian Burg
Comment 6 2015-02-14 20:22:06 PST
(In reply to comment #5) > Comment on attachment 246609 [details] > Proposed Fix > > View in context: > https://bugs.webkit.org/attachment.cgi?id=246609&action=review > > > Source/WebCore/inspector/CommandLineAPIHost.h:67 > > + , Inspector::ConsoleAgent* consoleAgent > > Drop the namespace here. > > > Source/WebCore/inspector/CommandLineAPIHost.h:105 > > + Inspector::ConsoleAgent* m_consoleAgent; > > Ditto. This class is still in WebCore namespace, and it's a header. So it can't be removed yet.
Brian Burg
Comment 7 2015-02-27 10:49:50 PST
Created attachment 247521 [details] Proposed Fix (rebased)
Joseph Pecoraro
Comment 8 2015-03-02 11:02:19 PST
Comment on attachment 247521 [details] Proposed Fix (rebased) r=me, looks like Win EWS is red, might be related.
Timothy Hatcher
Comment 9 2015-03-24 09:59:18 PDT
This might be stale now.
Joseph Pecoraro
Comment 10 2019-10-14 12:29:15 PDT
Stale now for sure. Clearing flags.
Note You need to log in before you can comment on or make changes to this bug.