Bug 141608

Summary:

Web Inspector: remove Inspector prefixes from inspector agent classes

Product:

WebKit

Reporter:

Brian Burg <burg>

Component:

Web Inspector

Assignee:

Nobody <webkit-unassigned>

Status:

NEW ---

Severity:

Normal

CC:

commit-queue, graouts, inspector-bugzilla-changes, joepeck, jonowells, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

141372

Bug Blocks:

141620

Attachments:

Description	Flags
Proposed Fix	none
Proposed Fix	none
Proposed Fix (rebased)	none

Description Brian Burg 2015-02-14 11:02:02 PST

Comment 1 Radar WebKit Bug Importer 2015-02-14 11:02:34 PST

<rdar://problem/19838400>

Comment 2 Brian Burg 2015-02-14 12:10:28 PST

Created attachment 246604 [details]
Proposed Fix

Comment 3 Brian Burg 2015-02-14 19:27:04 PST

Created attachment 246609 [details]
Proposed Fix

Comment 4 WebKit Commit Bot 2015-02-14 19:29:54 PST

This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)

Comment 5 Timothy Hatcher 2015-02-14 19:39:21 PST

Comment on attachment 246609 [details]
Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=246609&action=review

> Source/WebCore/inspector/CommandLineAPIHost.h:67
> +        , Inspector::ConsoleAgent* consoleAgent

Drop the namespace here.

> Source/WebCore/inspector/CommandLineAPIHost.h:105
> +    Inspector::ConsoleAgent* m_consoleAgent;

Ditto.

Comment 6 Brian Burg 2015-02-14 20:22:06 PST

(In reply to comment #5)
> Comment on attachment 246609 [details]
> Proposed Fix
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=246609&action=review
> 
> > Source/WebCore/inspector/CommandLineAPIHost.h:67
> > +        , Inspector::ConsoleAgent* consoleAgent
> 
> Drop the namespace here.
> 
> > Source/WebCore/inspector/CommandLineAPIHost.h:105
> > +    Inspector::ConsoleAgent* m_consoleAgent;
> 
> Ditto.

This class is still in WebCore namespace, and it's a header. So it can't be removed yet.

Comment 7 Brian Burg 2015-02-27 10:49:50 PST

Created attachment 247521 [details]
Proposed Fix (rebased)

Comment 8 Joseph Pecoraro 2015-03-02 11:02:19 PST

Comment on attachment 247521 [details]
Proposed Fix (rebased)

r=me, looks like Win EWS is red, might be related.

Comment 9 Timothy Hatcher 2015-03-24 09:59:18 PDT

This might be stale now.

Comment 10 Joseph Pecoraro 2019-10-14 12:29:15 PDT

Stale now for sure. Clearing flags.