Bug 141589

Summary:

JSContext Inspector: Do not stash console messages for non-debuggable JSContext

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

Web Inspector

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, ggaren, graouts, joepeck, jonowells, mark.lam, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Proposed Fix	timothy: review+, timothy: commit-queue+
[PATCH] Proposed Fix	none

Description Joseph Pecoraro 2015-02-13 20:08:16 PST

* SUMMARY
Do not stash console messages for non-debuggable JSContext.

For a JSContext in an application not inspectable, or a JSContext where remote debugging has been explicitly disabled (it is enabled by default), do not stash any console messages.

Comment 1 Joseph Pecoraro 2015-02-13 20:08:34 PST

<rdar://problem/19752014>

Comment 2 Joseph Pecoraro 2015-02-13 20:11:42 PST

Created attachment 246571 [details]
[PATCH] Proposed Fix

Comment 3 WebKit Commit Bot 2015-02-13 20:13:05 PST

Attachment 246571 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/inspector/JSGlobalObjectInspectorController.cpp:52:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 4 Joseph Pecoraro 2015-02-13 20:15:40 PST

Created attachment 246572 [details]
[PATCH] Proposed Fix

Comment 5 WebKit Commit Bot 2015-02-13 21:00:04 PST

Comment on attachment 246572 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 246572

Committed r180101: <http://trac.webkit.org/changeset/180101>

Comment 6 WebKit Commit Bot 2015-02-13 21:00:09 PST

All reviewed patches have been landed.  Closing bug.