Bug 141588

Summary: Update SPI availability annotations
Product: WebKit Reporter: mitz
Component: WebKit2Assignee: mitz
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, commit-queue, darin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Change some WK_IOS_TBA to 8_3
andersca: review-
Change some WK_IOS_TBA to 8_3
none
Change some WK_IOS_TBA to 8_3 none

mitz
Reported 2015-02-13 20:01:00 PST
Update SPI availability annotations
Attachments
Change some WK_IOS_TBA to 8_3 (2.19 KB, patch)
2015-02-13 20:04 PST, mitz 		andersca: review-
DetailsFormatted DiffDiff
Change some WK_IOS_TBA to 8_3 (2.77 KB, patch)
2015-02-16 08:58 PST, mitz 		no flags
DetailsFormatted DiffDiff
Change some WK_IOS_TBA to 8_3 (2.77 KB, patch)
2015-02-16 09:26 PST, mitz 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
mitz
Comment 1 2015-02-13 20:04:09 PST
Created attachment 246570 [details] Change some WK_IOS_TBA to 8_3
Darin Adler
Comment 2 2015-02-13 21:54:10 PST
Comment on attachment 246570 [details] Change some WK_IOS_TBA to 8_3 Do you know why this broke the EWS build?
Anders Carlsson
Comment 3 2015-02-13 22:39:28 PST
Comment on attachment 246570 [details] Change some WK_IOS_TBA to 8_3 Need to fix building on iOS 8.1 (or whatever it is EWS is using).
mitz
Comment 4 2015-02-13 23:22:11 PST
(In reply to comment #2) > Comment on attachment 246570 [details] > Change some WK_IOS_TBA to 8_3 > > Do you know why this broke the EWS build? Yes, __NSi_8_3 is not defined in the 8.1 SDK.
mitz
Comment 5 2015-02-16 08:58:47 PST
Created attachment 246654 [details] Change some WK_IOS_TBA to 8_3
WebKit Commit Bot
Comment 6 2015-02-16 09:00:49 PST
Attachment 246654 [details] did not pass style-queue: ERROR: Source/WebKit2/Shared/API/Cocoa/WKFoundation.h:52: Missing spaces around = [whitespace/operators] [4] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
mitz
Comment 7 2015-02-16 09:26:23 PST
Created attachment 246655 [details] Change some WK_IOS_TBA to 8_3
WebKit Commit Bot
Comment 8 2015-02-16 09:28:22 PST
Attachment 246655 [details] did not pass style-queue: ERROR: Source/WebKit2/Shared/API/Cocoa/WKFoundation.h:52: Missing spaces around = [whitespace/operators] [4] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 9 2015-02-16 10:56:16 PST
Comment on attachment 246655 [details] Change some WK_IOS_TBA to 8_3 Clearing flags on attachment: 246655 Committed r180158: <http://trac.webkit.org/changeset/180158>
WebKit Commit Bot
Comment 10 2015-02-16 10:56:20 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.