| Summary: | Update SPI availability annotations | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | mitz | ||||||||
| Component: | WebKit2 | Assignee: | mitz | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | andersca, commit-queue, darin | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
mitz
2015-02-13 20:01:00 PST
Created attachment 246570 [details]
Change some WK_IOS_TBA to 8_3
Comment on attachment 246570 [details]
Change some WK_IOS_TBA to 8_3
Do you know why this broke the EWS build?
Comment on attachment 246570 [details]
Change some WK_IOS_TBA to 8_3
Need to fix building on iOS 8.1 (or whatever it is EWS is using).
(In reply to comment #2) > Comment on attachment 246570 [details] > Change some WK_IOS_TBA to 8_3 > > Do you know why this broke the EWS build? Yes, __NSi_8_3 is not defined in the 8.1 SDK. Created attachment 246654 [details]
Change some WK_IOS_TBA to 8_3
Attachment 246654 [details] did not pass style-queue:
ERROR: Source/WebKit2/Shared/API/Cocoa/WKFoundation.h:52: Missing spaces around = [whitespace/operators] [4]
Total errors found: 1 in 4 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 246655 [details]
Change some WK_IOS_TBA to 8_3
Attachment 246655 [details] did not pass style-queue:
ERROR: Source/WebKit2/Shared/API/Cocoa/WKFoundation.h:52: Missing spaces around = [whitespace/operators] [4]
Total errors found: 1 in 4 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 246655 [details] Change some WK_IOS_TBA to 8_3 Clearing flags on attachment: 246655 Committed r180158: <http://trac.webkit.org/changeset/180158> All reviewed patches have been landed. Closing bug. |