Bug 141584

Summary:

REGRESSION: Page opens with enlarged font after visiting PDF, navigating back, then doing a process swap

Product:

WebKit

Reporter:

Beth Dakin <bdakin>

Component:

Layout and Rendering

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bdakin, simon.fraser, thorton

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	thorton: review+

Description Beth Dakin 2015-02-13 17:38:30 PST

REGRESSION: Page opens with enlarged font after visiting PDF, navigating back, then doing a process swap

Comment 1 Beth Dakin 2015-02-13 17:42:07 PST

Created attachment 246562 [details]
Patch

Comment 2 Tim Horton 2015-02-13 17:47:22 PST

Comment on attachment 246562 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=246562&action=review

> Source/WebKit2/UIProcess/WebPageProxy.cpp:2830
>      // WebPageProxy's cache of the value can get out of sync (e.g. in the case where a
>      // plugin is handling page scaling itself) so we should reset it to the default
>      // for standard main frame loads.

I wonder if this comment means that this code is only needed in the plugin case and that therefore you don't need to reset m_pageScaleFactor. But I don't really remember.

Comment 3 Beth Dakin 2015-02-14 14:57:01 PST

Thanks Tim! http://trac.webkit.org/changeset/180115