Bug 141579

Summary:

rel="noreferrer" should make window.opener null

Product:

WebKit

Reporter:

Alexey Proskuryakov <ap>

Component:

WebCore Misc.

Assignee:

Alexey Proskuryakov <ap>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

beidson, buildbot, commit-queue, darin, japhet, rniwa

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=28986

Attachments:

Description	Flags
proposed fix	buildbot: commit-queue-
Archive of layout-test-results from ews105 for mac-mavericks-wk2	none
proposed fix	none

Alexey Proskuryakov

Reported 2015-02-13 16:50:58 PST

That's what the spec says, and what other browsers do. See also: rdar://problem/19640886

Attachments
proposed fix (29.82 KB, patch) 2015-02-13 16:59 PST, Alexey Proskuryakov	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews105 for mac-mavericks-wk2 (672.79 KB, application/zip) 2015-02-13 17:42 PST, Build Bot	no flags	Details
proposed fix (29.76 KB, patch) 2015-02-13 21:59 PST, Alexey Proskuryakov	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Alexey Proskuryakov

Comment 1 2015-02-13 16:59:15 PST

Created attachment 246556 [details] proposed fix

Build Bot

Comment 2 2015-02-13 17:42:10 PST

Comment on attachment 246556 [details] proposed fix Attachment 246556 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5608730104168448 New failing tests: http/tests/navigation/target-blank-opener.html

Build Bot

Comment 3 2015-02-13 17:42:14 PST

Created attachment 246563 [details] Archive of layout-test-results from ews105 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5

Alexey Proskuryakov

Comment 4 2015-02-13 21:59:59 PST

Created attachment 246584 [details] proposed fix Forgot to remove an experimental change.

Darin Adler

Comment 5 2015-02-13 22:03:32 PST

Comment on attachment 246584 [details] proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=246584&action=review > Source/WebCore/loader/FrameLoader.h:110 > WEBCORE_EXPORT void loadFrameRequest(const FrameLoadRequest&, LockHistory, LockBackForwardList, // Called by submitForm, calls loadPostRequest and loadURL. > - PassRefPtr<Event>, PassRefPtr<FormState>, ShouldSendReferrer, AllowNavigationToInvalidURL); > + PassRefPtr<Event>, PassRefPtr<FormState>, ShouldSendReferrer, AllowNavigationToInvalidURL, NewFrameOpenerPolicy); This is really getting out of hand. I think we need to group these arguments all into an object rather than passing them all separately. Maybe just a struct?

Alexey Proskuryakov

Comment 6 2015-02-13 22:07:48 PST

I think that we already have one struct, FrameLoadRequest, but I'm not sure what belongs to it, and what doesn't. We may or may not want to try aligning with HTML5 terminology along the way. My concern is that the way the spec describes relationships between browsing contexts is quite complex.

WebKit Commit Bot

Comment 7 2015-02-14 10:16:09 PST

Comment on attachment 246584 [details] proposed fix Clearing flags on attachment: 246584 Committed r180110: <http://trac.webkit.org/changeset/180110>

WebKit Commit Bot

Comment 8 2015-02-14 10:16:12 PST

All reviewed patches have been landed. Closing bug.

Brady Eidson

Comment 9 2015-04-02 15:55:07 PDT

This was in radar as rdar://problem/20306425

Note You need to log in before you can comment on or make changes to this bug.