Bug 141574

Summary: Simplify ASSERT in lastRubyRun()
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dbates, esprehn+autocc, glenn, kondapallykalyan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch dbates: review+

zalan
Reported 2015-02-13 14:03:29 PST
ASSERT(!child || is<RenderRubyRun>(*child) || child->isBeforeContent() || child == rubyBeforeBlock(ruby)); is complex and redundant after r180064
Attachments
Patch (1.60 KB, patch)
2015-02-13 14:09 PST, zalan 		dbates: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2015-02-13 14:09:55 PST
Created attachment 246547 [details] Patch
Daniel Bates
Comment 2 2015-02-13 14:13:50 PST
Comment on attachment 246547 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=246547&action=review > Source/WebCore/rendering/RenderRuby.cpp:111 > + Nit: I don't feel that this empty line improves the readability of this code.
zalan
Comment 3 2015-02-13 14:26:59 PST
http://trac.webkit.org/changeset/180081
Note You need to log in before you can comment on or make changes to this bug.