Bug 141574

Summary:

Simplify ASSERT in lastRubyRun()

Product:

WebKit

Reporter:

zalan <zalan>

Component:

Layout and Rendering

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, dbates, esprehn+autocc, glenn, kondapallykalyan

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	dbates: review+

Description zalan 2015-02-13 14:03:29 PST

ASSERT(!child || is<RenderRubyRun>(*child) || child->isBeforeContent() || child == rubyBeforeBlock(ruby)); is complex and redundant after r180064

Comment 1 zalan 2015-02-13 14:09:55 PST

Created attachment 246547 [details]
Patch

Comment 2 Daniel Bates 2015-02-13 14:13:50 PST

Comment on attachment 246547 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=246547&action=review

> Source/WebCore/rendering/RenderRuby.cpp:111
> +

Nit: I don't feel that this empty line improves the readability of this code.

Comment 3 zalan 2015-02-13 14:26:59 PST

http://trac.webkit.org/changeset/180081