Bug 141563 – [EFL] Implement WebView::rootViewToScreen.

• Component: WebKit EFL
• Status: RESOLVED WONTFIX

[Julien Isorce]

Currently Source/WebKit2/UIProcess/CoordinatedGraphics/WebView.cpp::rootViewToScreen(const IntRect& rect) is not implemented.

[Julien Isorce]

Created attachment 246523 [details]
[EFL] Implement WebView::rootViewToScreen.

[Gyuyoung Kim]

Comment on attachment 246523 [details]
[EFL] Implement WebView::rootViewToScreen.

View in context: https://bugs.webkit.org/attachment.cgi?id=246523&action=review

I don't object to implement new function. However I think you need to explain why this function is needed for us.

> Source/WebKit2/ChangeLog:8
> +        All of these are just glue except EwkView::rootViewToScreen.

Could you explain what is a role of rootViewToScreen ?

> Source/WebKit2/UIProcess/WebPageProxy.h:1104
>      void screenToRootView(const WebCore::IntPoint& screenPoint, WebCore::IntPoint& windowPoint);

If you need to use rootViewToScreen(), don't we need to support screenToRootView() as well ?

> Source/WebKit2/UIProcess/WebPageProxy.h:-1104
> -    void rootViewToScreen(const WebCore::IntRect& viewRect, WebCore::IntRect& result);

This move should be approved by WK2 owner.

[Julien Isorce]

(In reply to comment #2)
> Comment on attachment 246523 [details]
> [EFL] Implement WebView::rootViewToScreen.
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=246523&action=review
> 
> I don't object to implement new function. However I think you need to
> explain why this function is needed for us.

First thx for the initial review.

This is not a really new function. This is an existing function that is currently implemented with "NotImplemented" for coordinates graphics: WebKit2/UIProcess/CoordinatedGraphics/WebView.cpp::WebView::rootViewToScreen.

I am not sure of the history but I suspect it was supported with WebKit1 but it has not been fully ported to WebKit2.

Also in Source/WebCore/platform/HostWindow.h there is
virtual IntRect rootViewToScreen(const IntRect&) const = 0;

Actually it is implemented for GTK already:
WebKit2/UIProcess/API/gtk/PageClientImpl.cpp::PageClientImpl::rootViewToScreen

Also the following code already exists in WebKit2/WebProcess/WebPage/WebPage.pp:

IntPoint WebPage::screenToRootView(const IntPoint& point)
{
    IntPoint windowPoint;
    sendSync(Messages::WebPageProxy::ScreenToRootView(point), Messages::WebPageProxy::ScreenToRootView::Reply(windowPoint));
    return windowPoint;
}
    
IntRect WebPage::rootViewToScreen(const IntRect& rect)
{
    IntRect screenRect;
    sendSync(Messages::WebPageProxy::RootViewToScreen(rect), Messages::WebPageProxy::RootViewToScreen::Reply(screenRect));
    return screenRect;
}


> 
> > Source/WebKit2/ChangeLog:8
> > +        All of these are just glue except EwkView::rootViewToScreen.
> 
> Could you explain what is a role of rootViewToScreen ?

The general idea is to be able to know the webkit view position in the screen within the webprocess. The webprocess needs some informations about the root view that only the UI process knows.

> 
> > Source/WebKit2/UIProcess/WebPageProxy.h:1104
> >      void screenToRootView(const WebCore::IntPoint& screenPoint, WebCore::IntPoint& windowPoint);
> 
> If you need to use rootViewToScreen(), don't we need to support
> screenToRootView() as well ?

Yes indeed I should add screenToRootView as well.

> 
> > Source/WebKit2/UIProcess/WebPageProxy.h:-1104
> > -    void rootViewToScreen(const WebCore::IntRect& viewRect, WebCore::IntRect& result);
> 
> This move should be approved by WK2 owner.

All right, I'll add some in CC

[Alex Christensen]

Comment on attachment 246523 [details]
[EFL] Implement WebView::rootViewToScreen.

EFL port was removed.  This patch is no longer necessary in trunk.

[Michael Catanzaro]

Closing this bug because the EFL port has been removed from trunk.

If you feel this bug applies to a different upstream WebKit port and was closed in error, please either update the title and reopen the bug, or leave a comment to request this.