Bug 141562

Summary:

[CSS Grid Layout] Remove the usage of Length(Undefined) in GridLength

Product:

WebKit

Reporter:

Sergio Villar Senin <svillar>

Component:

CSS

Assignee:

Sergio Villar Senin <svillar>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, darin, kling, koivisto, svillar

Priority:

Keywords:

BlinkMergeCandidate

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

140763

Attachments:

Description	Flags
Patch	cdumez: review+

Description Sergio Villar Senin 2015-02-13 07:19:50 PST

From Blink's r164154

"Neither of createGridTrackSize() nor createGridTrackBreadth() should be able to fail, so these are changed to return objects directly instead of taking an out reference (note that in general failing in applying properties is incorrect and we should catch these in the parser)."

Comment 1 Sergio Villar Senin 2015-02-13 08:17:45 PST

Created attachment 246527 [details]
Patch

Comment 2 Chris Dumez 2015-02-13 12:32:51 PST

Comment on attachment 246527 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=246527&action=review

r=me

> Source/WebCore/rendering/style/GridTrackSize.h:73
> +            DEPRECATED_DEFINE_STATIC_LOCAL(GridLength, minContent, (Length(MinContent)));

It is the opportunity to use a NeverDestroyed<>.

> Source/WebCore/rendering/style/GridTrackSize.h:82
> +            DEPRECATED_DEFINE_STATIC_LOCAL(GridLength, maxContent, (Length(MaxContent)));

It is the opportunity to use a NeverDestroyed<>.

Comment 3 Sergio Villar Senin 2015-02-16 01:42:42 PST

Committed r180140: <http://trac.webkit.org/changeset/180140>