| Summary: | Spinneret doesn't build against the new Win32 port. | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jake <jake> | ||||||||
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | aroben | ||||||||
| Priority: | P4 | ||||||||||
| Version: | 523.x (Safari 3) | ||||||||||
| Hardware: | PC | ||||||||||
| OS: | Windows XP | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Jake
2007-06-14 18:15:34 PDT
Created attachment 15038 [details]
Patch to allow spinneret to compile.
There were just a couple of changes required to get it to build.
Comment on attachment 15038 [details]
Patch to allow spinneret to compile.
This change looks good, but it can't land until you have a ChangeLog entry.
The prepare-ChangeLog script will do most of the work, but you will want to edit that and add info about what you changed and the bug title and url.
Created attachment 15056 [details]
A fix of the fix (includes changelog)
Oops! I forgot the changelog :)
Comment on attachment 15056 [details]
A fix of the fix (includes changelog)
- $safariPath = "cmd";
+ $safariPath = "echo";
This change looks wrong -- won't it break run-safari?
+ hr = viewExt->viewWindow(((OLE_HANDLE*) &gViewWindow));
You've got an extra set of parentheses here.
Created attachment 15095 [details]
A fix to the fix to the fix..
I'll get this right.. eventually!
Comment on attachment 15095 [details]
A fix to the fix to the fix..
r=me
|