Bug 14154 – Spinneret doesn't build against the new Win32 port.

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Jake]

Spinneret fails to build after the new win32 port.

[Jake]

Created attachment 15038 [details]
Patch to allow spinneret to compile.

There were just a couple of changes required to get it to build.

[Timothy Hatcher]

Comment on attachment 15038 [details]
Patch to allow spinneret to compile.

This change looks good, but it can't land until you have a ChangeLog entry.

The prepare-ChangeLog script will do most of the work, but you will want to edit that and add info about what you changed and the bug title and url.

[Jake]

Created attachment 15056 [details]
A fix of the fix (includes changelog)

Oops! I forgot the changelog :)

[Adam Roben (:aroben)]

Comment on attachment 15056 [details]
A fix of the fix (includes changelog)

-    $safariPath = "cmd";
+    $safariPath = "echo";

   This change looks wrong -- won't it break run-safari?

+    hr = viewExt->viewWindow(((OLE_HANDLE*) &gViewWindow));

   You've got an extra set of parentheses here.

[Jake]

Created attachment 15095 [details]
A fix to the fix to the fix..

I'll get this right.. eventually!

[Adam Roben (:aroben)]

Comment on attachment 15095 [details]
A fix to the fix to the fix..

r=me

[Mark Rowe (bdash)]

Jake, can you please be sure to use spaces rather than tabs for indentation.  It makes landing the patch easier if I don't have to detabify it first.

Landed in r23566.