|Summary:||Spinneret doesn't build against the new Win32 port.|
|Component:||Tools / Tests||Assignee:||Nobody <webkit-unassigned>|
|Version:||523.x (Safari 3)|
Description Jake 2007-06-14 18:15:34 PDT
Comment 1 Jake 2007-06-14 18:17:44 PDT
Created attachment 15038 [details] Patch to allow spinneret to compile. There were just a couple of changes required to get it to build.
Comment 2 Timothy Hatcher 2007-06-15 07:08:27 PDT
Comment on attachment 15038 [details] Patch to allow spinneret to compile. This change looks good, but it can't land until you have a ChangeLog entry. The prepare-ChangeLog script will do most of the work, but you will want to edit that and add info about what you changed and the bug title and url.
Comment 3 Jake 2007-06-15 07:54:44 PDT
Created attachment 15056 [details] A fix of the fix (includes changelog) Oops! I forgot the changelog :)
Comment 4 Adam Roben (:aroben) 2007-06-17 21:18:33 PDT
Comment on attachment 15056 [details] A fix of the fix (includes changelog) - $safariPath = "cmd"; + $safariPath = "echo"; This change looks wrong -- won't it break run-safari? + hr = viewExt->viewWindow(((OLE_HANDLE*) &gViewWindow)); You've got an extra set of parentheses here.
Comment 5 Jake 2007-06-17 22:43:15 PDT
Created attachment 15095 [details] A fix to the fix to the fix.. I'll get this right.. eventually!
Comment 6 Adam Roben (:aroben) 2007-06-17 22:44:46 PDT
Comment on attachment 15095 [details] A fix to the fix to the fix.. r=me