| Summary: | Additional emoji group support | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Enrica Casucci <enrica> | ||||||||||
| Component: | Layout and Rendering | Assignee: | Enrica Casucci <enrica> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | buildbot, commit-queue, esprehn+autocc, glenn, kondapallykalyan, mitz, mmaxfield, rniwa | ||||||||||
| Priority: | P2 | ||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Enrica Casucci
2015-02-12 15:03:06 PST
Created attachment 246479 [details]
Patch
Attachment 246479 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:211: One space before end of line comments [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:233: One space before end of line comments [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:252: One space before end of line comments [whitespace/comments] [5]
Total errors found: 3 in 6 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 246479 [details] Patch Attachment 246479 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5085886555357184 New failing tests: editing/deleting/regional-indicators.html editing/selection/regional-indicators.html Created attachment 246482 [details]
Archive of layout-test-results from ews105 for mac-mavericks-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Looking into the test failures. Comment on attachment 246479 [details] Patch Attachment 246479 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5381294405976064 New failing tests: editing/deleting/regional-indicators.html editing/selection/regional-indicators.html Created attachment 246484 [details]
Archive of layout-test-results from ews101 for mac-mavericks
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101 Port: mac-mavericks Platform: Mac OS X 10.9.5
Created attachment 246485 [details]
Patch2
Found a bug in the ICU rules. This fixes the failing tests.
Attachment 246485 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:211: One space before end of line comments [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:233: One space before end of line comments [whitespace/comments] [5]
ERROR: Source/WebCore/platform/text/TextBreakIterator.cpp:252: One space before end of line comments [whitespace/comments] [5]
Total errors found: 3 in 6 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Committed revision 180087. |