Bug 14153

Summary: Need RenderSVGViewportContainer sublcass for RenderSVGContainer
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: SVGAssignee: Nikolas Zimmermann <zimmermann>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 523.x (Safari 3)   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
Initial patch
rwlbuis: review+
LayoutTests results rwlbuis: review+

Eric Seidel (no email)
Reported 2007-06-14 17:27:21 PDT
Need RenderSVGViewportContainer sublcass for RenderSVGContainer RenderSVGContainer should be only for viewport-less containers (such as <g>) and RenderSVGViewportContainer should be for <pattern> and <symbol>, etc.
Attachments
Initial patch (27.39 KB, patch)
2007-08-10 07:31 PDT, Nikolas Zimmermann 		rwlbuis: review+
DetailsFormatted DiffDiff
LayoutTests results (236.71 KB, text/plain)
2007-08-10 07:31 PDT, Nikolas Zimmermann 		rwlbuis: review+
Details
View All Add attachment proposed patch, testcase, etc.
Nikolas Zimmermann
Comment 1 2007-08-10 07:31:08 PDT
Created attachment 15907 [details] Initial patch
Nikolas Zimmermann
Comment 2 2007-08-10 07:31:57 PDT
Created attachment 15908 [details] LayoutTests results
Rob Buis
Comment 3 2007-08-10 07:38:12 PDT
Comment on attachment 15907 [details] Initial patch Some whitespace changes may be unneeded, but otherwise fine.
Rob Buis
Comment 4 2007-08-10 07:38:39 PDT
Comment on attachment 15908 [details] LayoutTests results All fine, r=me.
Nikolas Zimmermann
Comment 5 2007-08-10 07:41:31 PDT
Landed in r(In reply to comment #0) > Need RenderSVGViewportContainer sublcass for RenderSVGContainer > > RenderSVGContainer should be only for viewport-less containers (such as <g>) > and RenderSVGViewportContainer should be for <pattern> and <symbol>, etc. Just one comment here: <pattern> don't have associated RenderObjects at all. Same for symbols. Currently it really only applies to makers and inner <svg> elements. Greetings, Niko
Nikolas Zimmermann
Comment 6 2007-08-10 07:41:54 PDT
Landed in r24991.
Note You need to log in before you can comment on or make changes to this bug.