Bug 141528

Summary: Fix multiple issues with text-underline-position:under
Product: WebKit Reporter: Dave Hyatt <hyatt>
Component: Layout and RenderingAssignee: Dave Hyatt <hyatt>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kondapallykalyan, mmaxfield
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch dino: review+

Dave Hyatt
Reported 2015-02-12 12:28:01 PST
text-underline-position: under has multiple correctness issues: (1) Doesn't work with vertical-lr (2) Is always including replaced elements in the "under" check (3) Doesn't limit the "under" check to the containing element with the text-decoration specified
Attachments
Patch (25.14 KB, patch)
2015-02-12 12:32 PST, Dave Hyatt 		no flags
DetailsFormatted DiffDiff
Patch (25.17 KB, patch)
2015-02-12 12:45 PST, Dave Hyatt 		dino: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dave Hyatt
Comment 1 2015-02-12 12:32:18 PST
Created attachment 246465 [details] Patch
WebKit Commit Bot
Comment 2 2015-02-12 12:34:05 PST
Attachment 246465 [details] did not pass style-queue: ERROR: Source/WebCore/rendering/RenderObject.cpp:2114: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/rendering/InlineFlowBox.h:297: The parameter name "textDecoration" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/rendering/InlineFlowBox.h:298: The parameter name "textDecoration" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/rendering/RenderElement.h:195: The parameter name "textDecoration" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 4 in 18 files If any of these errors are false positives, please file a bug against check-webkit-style.
Dave Hyatt
Comment 3 2015-02-12 12:45:12 PST
Created attachment 246468 [details] Patch Patch updated to Tot and with style fixes.
Dave Hyatt
Comment 4 2015-02-16 10:03:48 PST
Fixed.
Note You need to log in before you can comment on or make changes to this bug.