Bug 141521

Summary: really stop using export files
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: WebCore Misc.Assignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ddkilzer, dino, kondapallykalyan, noam, roger_fong
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 141491    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch mrowe: review+

Alex Christensen
Reported 2015-02-12 10:48:02 PST
I don't think the switch was made all the way. Let's land this little bit and see if it breaks anything.
Attachments
Patch (2.18 KB, patch)
2015-02-12 10:50 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (3.28 KB, patch)
2015-02-12 11:49 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (2.80 KB, patch)
2015-02-12 12:40 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (3.95 KB, patch)
2015-02-12 14:39 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (4.40 KB, patch)
2015-02-13 13:46 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (4.27 KB, patch)
2015-02-13 14:10 PST, Alex Christensen 		mrowe: review+
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2015-02-12 10:50:39 PST
Created attachment 246453 [details] Patch
Alex Christensen
Comment 2 2015-02-12 11:49:44 PST
Created attachment 246459 [details] Patch
Alex Christensen
Comment 3 2015-02-12 12:40:03 PST
Created attachment 246466 [details] Patch
Alex Christensen
Comment 4 2015-02-12 14:39:33 PST
Created attachment 246476 [details] Patch
Alex Christensen
Comment 5 2015-02-13 13:46:27 PST
Created attachment 246546 [details] Patch
Alex Christensen
Comment 6 2015-02-13 14:10:53 PST
Created attachment 246548 [details] Patch
Mark Rowe (bdash)
Comment 7 2015-02-13 14:20:44 PST
Comment on attachment 246548 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=246548&action=review > Source/WebCore/ChangeLog:11 > + Added list of symbols not to export (needed by xcode 5.0.2). Xcode > Source/WebCore/Configurations/WebCore.xcconfig:54 > +UNEXPORTED_SYMBOLS_FILE_xcode_0500 = Configurations/WebCoreUnexportedSymbols; WebCore.unexp would be more in line with our existing convention for symbol lists. WebCoreUnexported.symbols would be fine too. Anything with a file extension would be an improvement. > Source/WebCore/Configurations/WebCoreUnexportedSymbols:1 > +__ZTCNSt3__118basic_stringstreamIcNS_11char_traitsIcEENS_9allocatorIcEEEE0_NS_13basic_istreamIcS2_EE I think these files support # comments. This could do with one mentioning that it's only used by Xcode 5.0.x and should be removed when we no longer support that version.
Alex Christensen
Comment 8 2015-02-13 14:40:59 PST
http://trac.webkit.org/changeset/180082
David Kilzer (:ddkilzer)
Comment 9 2015-02-14 09:17:25 PST
(In reply to comment #8) > http://trac.webkit.org/changeset/180082 Follow-up build fix for Mountain Lion: Committed r180109: <http://trac.webkit.org/changeset/180109>
Note You need to log in before you can comment on or make changes to this bug.