Bug 141507

Summary: Fix the gperf related build issue on the WinCairo bot
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   

Description Csaba Osztrogonác 2015-02-12 01:39:46 PST 
21>  /usr/bin/perl /home/webkitbot/win-cairo-release/build/Source/WebCore/make-hash-tools.pl . /home/webkitbot/win-cairo-release/build/Source/WebCore/platform/ColorData.gperf
21>  /home/webkitbot/win-cairo-release/build/Source/WebCore/platform/ColorData.gperf:25: warning: junk after %% is ignored
21>  /home/webkitbot/win-cairo-release/build/Source/WebCore/platform/ColorData.gperf:13: warning: junk after %} is ignored
21>  /home/webkitbot/win-cairo-release/build/Source/WebCore/platform/ColorData.gperf:14: junk after declaration
21>  calling gperf failed: 256 at /home/webkitbot/win-cairo-release/build/Source/WebCore/make-hash-tools.pl line 40.
21>  /home/webkitbot/win-cairo-release/build/Source/WebCore/DerivedSources.make:909: recipe for target 'ColorData.cpp' failed
21>  make: *** [ColorData.cpp] Error 1
21>  make: *** Waiting for unfinished jobs....
21>  Failed to build /home/webkitbot/win-cairo-release/build/Source/WebCore/DerivedSources.make:  at build-generated-files.pl line 78.
21>NMAKE : fatal error U1077: 'perl' : return code '0x2'
21>  Stop.

before: https://build.webkit.org/builders/WinCairo%2064-Bit%20Release/builds/43959
after: https://build.webkit.org/builders/WinCairo%2064-Bit%20Release/builds/43960

r179980 couldn't cause the failure, so the problem must be a bot issue.
Comment 1 Csaba Osztrogonác 2015-02-12 01:40:41 PST 
force clean build is in progress, maybe it helps: 
https://build.webkit.org/builders/WinCairo%2064-Bit%20Release/builds/43964
Comment 2 Csaba Osztrogonác 2015-02-12 02:16:12 PST 
(In reply to comment #1)
> force clean build is in progress, maybe it helps: 
> https://build.webkit.org/builders/WinCairo%2064-Bit%20Release/builds/43964

It didn't help, clean build failed with the same error.
Comment 3 Alex Christensen 2015-02-12 07:53:52 PST 
The problem was the line endings that svn used.  I went in manually and replaced \r\n with \n and it fixed it, but there ought to be a way to suppress those warnings.  This problem will occur again when it checks out that file again.
Comment 4 Csaba Osztrogonác 2015-02-12 08:01:54 PST 
(In reply to comment #3)
> The problem was the line endings that svn used.  I went in manually and
> replaced \r\n with \n and it fixed it, but there ought to be a way to
> suppress those warnings.  This problem will occur again when it checks out
> that file again.

Now the svn:eol-style property of ColorData.gperf is native,
maybe changing it to LF would make Windows, Linux and OSX happy.

But how come it isn't problem on the Apple Windows buildbots?
Comment 5 Alex Christensen 2015-02-12 11:35:00 PST 
In Tools/CygwinDownloader/cygwin-downloader.py, subversion 1.7.14-1 is downloaded.  I did not specify the version, so I probably got a newer version than that.

r=me for changing that svn property in this and any other gperf files.  There would be no diff, so no patch to review.  It shouldn't hurt anything.
Comment 6 Csaba Osztrogonác 2015-02-13 01:20:30 PST 
landed in http://trac.webkit.org/changeset/180036