Summary: | Fix the gperf related build issue on the WinCairo bot | ||
---|---|---|---|
Product: | WebKit | Reporter: | Csaba Osztrogonác <ossy> |
Component: | New Bugs | Assignee: | Alex Christensen <achristensen> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | bfulgham, ossy |
Priority: | P2 | ||
Version: | 528+ (Nightly build) | ||
Hardware: | Unspecified | ||
OS: | Unspecified |
Description
Csaba Osztrogonác
2015-02-12 01:39:46 PST
force clean build is in progress, maybe it helps: https://build.webkit.org/builders/WinCairo%2064-Bit%20Release/builds/43964 (In reply to comment #1) > force clean build is in progress, maybe it helps: > https://build.webkit.org/builders/WinCairo%2064-Bit%20Release/builds/43964 It didn't help, clean build failed with the same error. The problem was the line endings that svn used. I went in manually and replaced \r\n with \n and it fixed it, but there ought to be a way to suppress those warnings. This problem will occur again when it checks out that file again. (In reply to comment #3) > The problem was the line endings that svn used. I went in manually and > replaced \r\n with \n and it fixed it, but there ought to be a way to > suppress those warnings. This problem will occur again when it checks out > that file again. Now the svn:eol-style property of ColorData.gperf is native, maybe changing it to LF would make Windows, Linux and OSX happy. But how come it isn't problem on the Apple Windows buildbots? In Tools/CygwinDownloader/cygwin-downloader.py, subversion 1.7.14-1 is downloaded. I did not specify the version, so I probably got a newer version than that. r=me for changing that svn property in this and any other gperf files. There would be no diff, so no patch to review. It shouldn't hurt anything. landed in http://trac.webkit.org/changeset/180036 |